[jira] Commented: (TAP5-1359) add 'registryAboutToShutdown' handler

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964954#action_12964954 ] 

Howard M. Lewis Ship commented on TAP5-1359:
--------------------------------------------

We must be working on similar things, I hit a similar problem and was about to add a similar issue.

I think I prefer the name registryWillShutdown().  It's really a change to RegistryShutdownHub:  a new method, addRegistryWillShutdownListener(RegistryShutdownListener listener).  I don't see it as a problem that we use the same interface for the two different cases.

I'm also thinking about a @RegistryWillShutdown annotation that could be applied to a public void method that would handle the registration automatically, and perform last-minute injection as well. However, shutdown listeners are rare enough that this is not a huge win to implement.

> add 'registryAboutToShutdown' handler
> -------------------------------------
>
>                 Key: TAP5-1359
>                 URL: https://issues.apache.org/jira/browse/TAP5-1359
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>
> It is impossible to inject a service into a handler of 'RegistryShutdownListener .registryDidShutdown' since the registry is already shutdown at this point. this makes it difficult to perform some more intricate termination logic when multiple services need to collude.
> I propose the inclusion of a new interface 'RegistryAboutToShutdownListener' with the method 'registryAboutToShutDown'.
> In the case of a tapestry application, it would need to be called after Http requests have been disallowed, but before the registry becomes unusable.
> There may need to be some ordered configuration to control service dependencies as they shut down, and I expect some other considerations I haven't thought of....

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.