[jira] [Commented] (KAFKA-4920) Stamped should implement equals

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377448#comment-16377448 ] 

ASF GitHub Bot commented on KAFKA-4920:
---------------------------------------

guozhangwang opened a new pull request #4622: KAFKA-4920: Stamped implements equals
URL: https://github.com/apache/kafka/pull/4622
 
 
   This is a straight forward change.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Stamped should implement equals
> -------------------------------
>
>                 Key: KAFKA-4920
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4920
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Marc Juchli
>            Priority: Minor
>
> We ran FundBug, which resulted in the "Bad practice warning": 
> Bug type EQ_COMPARETO_USE_OBJECT_EQUALS (click for details) 
> In class org.apache.kafka.streams.processor.internals.Stamped
> In method org.apache.kafka.streams.processor.internals.Stamped.compareTo(Object)
> At Stamped.java:[lines 31-35]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)