You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/01 23:16:01 UTC
[GitHub] [hudi] sreeram26 opened a new pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
sreeram26 opened a new pull request #1898:
URL: https://github.com/apache/hudi/pull/1898
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
Attempt to fix this [issue](https://github.com/apache/hudi/issues/1586)
## Brief change log
Updating the way `--hoodie-conf` is parsed for `HoodieDeltaStreamer`. This also includes adding some functional tests for such command line argument parsing
## Verify this pull request
This change added tests and can be verified as follows:
- * Added a functional test in code *
- *Manually verified the change by running a job locally.*
Tried running
```
mvn clean package -DskipITs
TestClientRollback>HoodieClientTestBase.setUp:78->HoodieClientTestHarness.initResources:100->HoodieClientTestHarness.initSparkContexts:139->HoodieClientTestHarness.initSparkContexts:126 » Spark
```
So planning to see if the same error happens in CI, if so attempt to fix it. Otherwise, something with my setup locally is wrong
## Committer checklist
- [x] Has a corresponding JIRA in PR title & commit
- [x] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sreeram26 commented on a change in pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
sreeram26 commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464568735
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -306,16 +317,106 @@ public boolean isInlineCompactionEnabled() {
return !continuousMode && !forceDisableCompaction
&& HoodieTableType.MERGE_ON_READ.equals(HoodieTableType.valueOf(tableType));
}
+
Review comment:
Yes I wanted to add equals() for better testability and hence added hashcode() as both go hand-in-hand
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter commented on pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#issuecomment-667615546
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1898?src=pr&el=h1) Report
> Merging [#1898](https://codecov.io/gh/apache/hudi/pull/1898?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/10e426879237b636f8b5913ac931dd7f8af8b817&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `20.93%`.
[](https://codecov.io/gh/apache/hudi/pull/1898?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1898 +/- ##
============================================
- Coverage 61.40% 61.31% -0.09%
- Complexity 3800 3801 +1
============================================
Files 458 458
Lines 19573 19612 +39
Branches 1959 1988 +29
============================================
+ Hits 12018 12025 +7
- Misses 6741 6743 +2
- Partials 814 844 +30
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #hudicli | `69.48% <ø> (ø)` | `1547.00 <ø> (ø)` | |
| #hudiclient | `79.21% <ø> (ø)` | `1357.00 <ø> (ø)` | |
| #hudicommon | `55.07% <ø> (ø)` | `1518.00 <ø> (ø)` | |
| #hudihadoopmr | `38.99% <ø> (ø)` | `163.00 <ø> (ø)` | |
| #hudihivesync | `72.01% <ø> (ø)` | `121.00 <ø> (ø)` | |
| #hudispark | `49.24% <ø> (ø)` | `124.00 <ø> (ø)` | |
| #huditimelineservice | `63.47% <ø> (ø)` | `47.00 <ø> (ø)` | |
| #hudiutilities | `72.72% <20.93%> (-1.41%)` | `281.00 <1.00> (+1.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1898?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/hudi/pull/1898/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `70.70% <20.93%> (-9.49%)` | `12.00 <1.00> (+1.00)` | :arrow_down: |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar merged pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
bvaradar merged pull request #1898:
URL: https://github.com/apache/hudi/pull/1898
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sreeram26 commented on pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
sreeram26 commented on pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#issuecomment-667599251
Trying to fix the build failure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sreeram26 commented on a change in pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
sreeram26 commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464681579
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -165,6 +168,12 @@ public Operation convert(String value) throws ParameterException {
}
}
+ private static final class VoidSplitter implements IParameterSplitter {
Review comment:
I was a little skeptical about making this change apply for all CLIs. But on second thought, looked at all documentation and README files all of them have `--hoodie-conf A --hoodie-conf B` way so no one in theory should be sending `--hoodie-conf A,B` in their usecases. So will move it to common and apply this change for all of the classes using hoodie-conf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhedoubushishi commented on a change in pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
zhedoubushishi commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464706175
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -165,6 +168,12 @@ public Operation convert(String value) throws ParameterException {
}
}
+ private static final class VoidSplitter implements IParameterSplitter {
Review comment:
Thanks for confirming!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhedoubushishi commented on a change in pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
zhedoubushishi commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464660634
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -165,6 +168,12 @@ public Operation convert(String value) throws ParameterException {
}
}
+ private static final class VoidSplitter implements IParameterSplitter {
Review comment:
How about make this class public and move it to a more general package e.g. ```hudi-common```?
There are some other classes which might also need this ```VoidSplitter```, e.g. https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java#L280, https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java#L92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhedoubushishi commented on a change in pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
zhedoubushishi commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464660634
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -165,6 +168,12 @@ public Operation convert(String value) throws ParameterException {
}
}
+ private static final class VoidSplitter implements IParameterSplitter {
Review comment:
How about making this class public and move it to a more general package e.g. ```hudi-common```?
There are some other classes which might also need this ```VoidSplitter```, e.g. https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java#L280, https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java#L92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhedoubushishi commented on a change in pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
zhedoubushishi commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464660634
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -165,6 +168,12 @@ public Operation convert(String value) throws ParameterException {
}
}
+ private static final class VoidSplitter implements IParameterSplitter {
Review comment:
How about making this class public and moving it to a more general package e.g. ```hudi-common```?
There are some other classes which might also need this ```VoidSplitter```, e.g. https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java#L280, https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java#L92
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#issuecomment-668387195
LGTM! Please resolve the conflicts @sreeram26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sreeram26 commented on a change in pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
sreeram26 commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464681579
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -165,6 +168,12 @@ public Operation convert(String value) throws ParameterException {
}
}
+ private static final class VoidSplitter implements IParameterSplitter {
Review comment:
I was a little skeptical about making this change apply for all CLIs. But on second thought, looked at documentation and README files, all of them have `--hoodie-conf A --hoodie-conf B` way so no one in theory should be sending `--hoodie-conf A,B` in their usecases. So will move it to common and apply this change for all of the classes using hoodie-conf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sreeram26 commented on pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
sreeram26 commented on pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#issuecomment-667681236
Testing in docker
```
root@adhoc-2:/opt# spark-submit \
> --class org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer $HUDI_UTILITIES_BUNDLE \
> --table-type COPY_ON_WRITE \
> --source-class org.apache.hudi.utilities.sources.JsonKafkaSource \
> --source-ordering-field ts \
> --target-base-path /user/hive/warehouse/stock_ticks_cow \
> --target-table stock_ticks_cow --props /var/demo/config/kafka-source.properties \
> --schemaprovider-class org.apache.hudi.utilities.schema.FilebasedSchemaProvider \
> --hoodie-conf hoodie.datasource.write.recordkey.field=key,symbol \
> --hoodie-conf hoodie.datasource.write.keygenerator.class=org.apache.hudi.keygen.ComplexKeyGenerator
0: jdbc:hive2://hiveserver:10000> select `_hoodie_record_key` from stock_ticks_cow where symbol = 'GOOG';
+-------------------------------------+--+
| _hoodie_record_key |
+-------------------------------------+--+
| key:GOOG_2018-08-31 10,symbol:GOOG |
| key:GOOG_2018-08-31 09,symbol:GOOG |
+-------------------------------------+--+
2 rows selected (0.302 seconds)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on a change in pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r465186323
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -165,6 +168,12 @@ public Operation convert(String value) throws ParameterException {
}
}
+ private static final class VoidSplitter implements IParameterSplitter {
Review comment:
@zhedoubushishi : Lets not bring in jcommander dependency to hudi-common. hudi-common is a core package used across different environments. This can be made the first level class but lets keep it in hudi-utilities : org.apache.hudi.utilities
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on a change in pull request #1898: [HUDI-1140] Fix Jcommander issue for --hoodie-conf in DeltaStreamer
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1898:
URL: https://github.com/apache/hudi/pull/1898#discussion_r464564500
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -306,16 +317,106 @@ public boolean isInlineCompactionEnabled() {
return !continuousMode && !forceDisableCompaction
&& HoodieTableType.MERGE_ON_READ.equals(HoodieTableType.valueOf(tableType));
}
+
Review comment:
Question : Any specific reason why equals/hashcode are added ? Was it added as part of general best-practices ?
##########
File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java
##########
@@ -394,6 +414,95 @@ public void testProps() {
props.getString("hoodie.datasource.write.keygenerator.class"));
}
+ private static HoodieDeltaStreamer.Config getBaseConfig() {
+ // Base config with all required fields
+ HoodieDeltaStreamer.Config base = new HoodieDeltaStreamer.Config();
+ base.targetBasePath = TGT_BASE_PATH_VALUE;
+ base.tableType = TABLE_TYPE_VALUE;
+ base.targetTableName = TARGET_TABLE_VALUE;
+ return base;
+ }
+
+ private static Stream<Arguments> provideValidCliArgs() {
+
+ HoodieDeltaStreamer.Config base = getBaseConfig();
+ // String parameter
+ HoodieDeltaStreamer.Config conf1 = getBaseConfig();
+ conf1.baseFileFormat = BASE_FILE_FORMAT_VALUE;
+
+ // Integer parameter
+ HoodieDeltaStreamer.Config conf2 = getBaseConfig();
+ conf2.sourceLimit = Long.parseLong(SOURCE_LIMIT_VALUE);
+
+ // Boolean Parameter
+ HoodieDeltaStreamer.Config conf3 = getBaseConfig();
+ conf3.enableHiveSync = true;
+
+ // ArrayList Parameter with 1 value
+ HoodieDeltaStreamer.Config conf4 = getBaseConfig();
+ conf4.configs = Arrays.asList(HOODIE_CONF_VALUE1);
+
+ // ArrayList Parameter with comma separated values
+ HoodieDeltaStreamer.Config conf5 = getBaseConfig();
+ conf5.configs = Arrays.asList(HOODIE_CONF_VALUE2);
+
+ // Multiple ArrayList values
+ HoodieDeltaStreamer.Config conf6 = getBaseConfig();
+ conf6.configs = Arrays.asList(HOODIE_CONF_VALUE1, HOODIE_CONF_VALUE2);
+
+ // Super set of all cases
+ HoodieDeltaStreamer.Config conf = getBaseConfig();
+ conf.baseFileFormat = BASE_FILE_FORMAT_VALUE;
+ conf.sourceLimit = Long.parseLong(SOURCE_LIMIT_VALUE);
+ conf.enableHiveSync = true;
+ conf.configs = Arrays.asList(HOODIE_CONF_VALUE1, HOODIE_CONF_VALUE2);
+
+ String[] allConfig = new String[]{TGT_BASE_PATH_PARAM, TGT_BASE_PATH_VALUE, SOURCE_LIMIT_PARAM,
+ SOURCE_LIMIT_VALUE, TABLE_TYPE_PARAM, TABLE_TYPE_VALUE, TARGET_TABLE_PARAM, TARGET_TABLE_VALUE,
+ BASE_FILE_FORMAT_PARAM, BASE_FILE_FORMAT_VALUE, ENABLE_HIVE_SYNC_PARAM, HOODIE_CONF_PARAM, HOODIE_CONF_VALUE1,
+ HOODIE_CONF_PARAM, HOODIE_CONF_VALUE2};
+
+ return Stream.of(
+ // Base
+ Arguments.of(new String[] {TGT_BASE_PATH_PARAM, TGT_BASE_PATH_VALUE,
+ TABLE_TYPE_PARAM, TABLE_TYPE_VALUE, TARGET_TABLE_PARAM, TARGET_TABLE_VALUE}, base),
+ // String
+ Arguments.of(new String[] {TGT_BASE_PATH_PARAM, TGT_BASE_PATH_VALUE,
+ TABLE_TYPE_PARAM, TABLE_TYPE_VALUE, TARGET_TABLE_PARAM, TARGET_TABLE_VALUE,
+ BASE_FILE_FORMAT_PARAM, BASE_FILE_FORMAT_VALUE}, conf1),
+ // Integer
+ Arguments.of(new String[] {TGT_BASE_PATH_PARAM, TGT_BASE_PATH_VALUE,
+ TABLE_TYPE_PARAM, TABLE_TYPE_VALUE, TARGET_TABLE_PARAM, TARGET_TABLE_VALUE,
+ SOURCE_LIMIT_PARAM, SOURCE_LIMIT_VALUE}, conf2),
+ // Boolean
+ Arguments.of(new String[] {TGT_BASE_PATH_PARAM, TGT_BASE_PATH_VALUE,
+ TABLE_TYPE_PARAM, TABLE_TYPE_VALUE, TARGET_TABLE_PARAM, TARGET_TABLE_VALUE,
+ ENABLE_HIVE_SYNC_PARAM}, conf3),
+ // Array List 1
+ Arguments.of(new String[] {TGT_BASE_PATH_PARAM, TGT_BASE_PATH_VALUE,
+ TABLE_TYPE_PARAM, TABLE_TYPE_VALUE, TARGET_TABLE_PARAM, TARGET_TABLE_VALUE,
+ HOODIE_CONF_PARAM, HOODIE_CONF_VALUE1}, conf4),
+ // Array List with comma
+ Arguments.of(new String[] {TGT_BASE_PATH_PARAM, TGT_BASE_PATH_VALUE,
+ TABLE_TYPE_PARAM, TABLE_TYPE_VALUE, TARGET_TABLE_PARAM, TARGET_TABLE_VALUE,
+ HOODIE_CONF_PARAM, HOODIE_CONF_VALUE2}, conf5),
+ // Array list with multiple values
+ Arguments.of(new String[] {TGT_BASE_PATH_PARAM, TGT_BASE_PATH_VALUE,
+ TABLE_TYPE_PARAM, TABLE_TYPE_VALUE, TARGET_TABLE_PARAM, TARGET_TABLE_VALUE,
+ HOODIE_CONF_PARAM, HOODIE_CONF_VALUE1, HOODIE_CONF_PARAM, HOODIE_CONF_VALUE2}, conf6),
+ // All
+ Arguments.of(allConfig, conf)
+ );
+ }
+
+ @ParameterizedTest
+ @MethodSource("provideValidCliArgs")
+ public void testValidCommandLineArgs(String[] args, HoodieDeltaStreamer.Config expected) {
+ System.out.println("Expected: ");
Review comment:
can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org