[jira] [Resolved] (LUCENE-8188) OpenNLPOpsFactory leaks filehandles of models

["Hoss Man (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved LUCENE-8188.
------------------------------
       Resolution: Fixed
         Assignee: Hoss Man
    Fix Version/s: 7.3
                   master (8.0)

> OpenNLPOpsFactory leaks filehandles of models
> ---------------------------------------------
>
>                 Key: LUCENE-8188
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8188
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Major
>             Fix For: master (8.0), 7.3
>
>         Attachments: LUCENE-8188.patch
>
>
> I appears that all methods in {{OpenNLPOpsFactory}} which use a {{ResourceLoader}} to get an InputStream to use for building a model are not closing those {{InputStreams}}
> This doesn't seem to negatively affect any existing {{lucene/analysis/opennlp}} tests, because the JVM doesn't know/care that there is a filehandle still open at the end of the test (is there a way to make the test complain?)  but it does seem to cause a Solr level test failure on windows (SOLR-12046) because the solr tests create a temp dir where pre-built models are copied for use, and when the test completes the cleanup attempts to delete those copies of the files but windows won't let it because they are still open.
> presumably if a {{lucene/analysis/opennlp}} test also made a copy of the files a similar failure would be triggered -- but only on windows



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org