You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/28 04:03:10 UTC
[GitHub] [airflow] uranusjr opened a new pull request #17280: Opmitise LoggingMixin.log
uranusjr opened a new pull request #17280:
URL: https://github.com/apache/airflow/pull/17280
The log instance is now instantiated per class, instead of per instance, saving duplicated `getLogger()` calls. Those `getLogger()` calls would return the same logger instance anyway, so the functionality is effectively the same; only the function call overhead os saved.
The `log` property is also converted to a `cached_property`, so the `is None` check would only happen once per instance, instead of every time the property is accessed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17280: Opmitise LoggingMixin.log
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17280:
URL: https://github.com/apache/airflow/pull/17280#issuecomment-888510152
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #17280: Opmitise LoggingMixin.log
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #17280:
URL: https://github.com/apache/airflow/pull/17280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #17280: Opmitise LoggingMixin.log
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #17280:
URL: https://github.com/apache/airflow/pull/17280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org