[jira] [Comment Edited] (CHAIN-40) ContextBase should use LinkedHashMap

["Steve Westwood (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CHAIN-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601194#comment-13601194 ] 

Steve Westwood edited comment on CHAIN-40 at 3/13/13 2:37 PM:
--------------------------------------------------------------

This issue is obsolete given the work in CHAIN-53 to accommodate JDK 1.5 and generics. Whereas the older version of ContextBase extended HashMap, this current trunk version uses ConcurrentHashMap. 

Suggest that this issue be closed.
                
      was (Author: hexsaw):
    This is obsolete given the work in CHAIN-53 to accommodate JDK 1.5 and generics. Whereas the older version of ContextBase extended HashMap, this current trunk version uses ConcurrentHashMap.
                  
> ContextBase should use LinkedHashMap
> ------------------------------------
>
>                 Key: CHAIN-40
>                 URL: https://issues.apache.org/jira/browse/CHAIN-40
>             Project: Commons Chain
>          Issue Type: Improvement
>            Reporter: Cédric BODIN
>            Priority: Minor
>
> org.apache.commons.chain.impl.ContextBase should use java.util.LinkedHashMap (instead of java.util.HashMap) : as its superclass,  and as the java.util.Map implementation for its "descriptors" attribute.
> Indeed LinkedHashMap allow "insertion-order" iteration over the context, which is an additional information about the chain execution (to know the order of the commands into the chain).
> Moreover LinkedHashMap is a HashMap : so this enhancement is "transparent" for users who didn't/don't/won't want to presume about context's iteration order.
> Thanks in advance.
> Cédric BODIN

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira