[GitHub] [incubator-kyuubi] yanghua commented on a diff in pull request #2717: [SUB-TASK][KPIP-4] Introduce jdbc session state store for batch session multiple HA

[GitBox <gi...@apache.org>]

yanghua commented on code in PR #2717:
URL: https://github.com/apache/incubator-kyuubi/pull/2717#discussion_r884622500


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -855,6 +861,85 @@ object KyuubiConf {
       .intConf
       .createWithDefault(100)
 
+  val SERVER_STATE_STORE_CLASS: ConfigEntry[String] =
+    buildConf("kyuubi.server.state.store.class")
+      .doc("Class name for server state store.")
+      .version("1.6.0")
+      .stringConf
+      .createWithDefault("org.apache.kyuubi.server.statestore.jdbc.JDBCStateStore")
+
+  val SERVER_STATE_STORE_JDBC_DATABASE_TYPE: ConfigEntry[String] =
+    buildConf("kyuubi.server.state.store.jdbc.database.type")

Review Comment:
   Have you considered making the config items related to the JDBC store locally? Not a global configuration item.
   
   Considering if it's a pluggable mechanism, then this config belongs to a plugin-level configuration?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org