You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "geruh (via GitHub)" <gi...@apache.org> on 2026/01/26 01:36:03 UTC

[PR] chore: remove redundant flynt pre-commit hook [iceberg-python]

geruh opened a new pull request, #2953:
URL: https://github.com/apache/iceberg-python/pull/2953

   # Rationale for this change
   
   While working on the `ty` integration, I've been auditing the pre-commit hooks. This PR removes the `flynt` pre-commit hook since it;s redundant with ruff's `UP031` and `UP032` rules which are already enabled via the `UP` selector in  our `ruff.toml`.
   
   `flynt` converts `.format()` and `%` style string formatting to f-strings. Ruff's pyupgrade rules do the same:
   - **UP031**: `printf-string-formatting` - converts `%` formatting
   - **UP032**: `f-string` - converts `.format()` calls
   
   and both produce identical results
   
   ## Are these changes tested?
   
   make lint
   
   Manual tests:
   
   Code: `"Hello, {}".format(name)` 
    - flynt: `f"Hello, {name}"` 
    - ruff: `f"Hello, {name}"` 
   
   ## Are there any user-facing changes?
   
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: remove redundant flynt pre-commit hook [iceberg-python]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #2953:
URL: https://github.com/apache/iceberg-python/pull/2953


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org