You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/10/14 20:31:51 UTC
Review Request 39324: Updated protobuf::parse to handle JSON "null"
values.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39324/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jie Yu.
Repository: mesos
Description
-------
This allows us to handle JSON objects that have some fields set to "null".
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9eaba668d5215c108849055fe92163da4d
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2d9bb61cb3b832c1136dfe9a77f8421768
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798f06f89f89f412da0490615c8ae03c90b6
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d04822ad043a3f5aebe531b34c0a9809155
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c98b74513c374dac4673fcb445e30beef61
Diff: https://reviews.apache.org/r/39324/diff/
Testing
-------
Added a new tests in stout::protobuf_tests and ran make check.
Thanks,
Kapil Arya
Re: Review Request 39324: Updated protobuf::parse to handle JSON
"null" values.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39324/#review102707
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39324]
All tests passed.
- Mesos ReviewBot
On Oct. 14, 2015, 6:31 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39324/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 6:31 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This allows us to handle JSON objects that have some fields set to "null".
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9eaba668d5215c108849055fe92163da4d
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 68328a2d9bb61cb3b832c1136dfe9a77f8421768
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 8ebb798f06f89f89f412da0490615c8ae03c90b6
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 34eb6d04822ad043a3f5aebe531b34c0a9809155
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto 920f5c98b74513c374dac4673fcb445e30beef61
>
> Diff: https://reviews.apache.org/r/39324/diff/
>
>
> Testing
> -------
>
> Added a new tests in stout::protobuf_tests and ran make check.
>
>
> Thanks,
>
> Kapil Arya
>
>