You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/18 14:39:07 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #905: Add
Google Mail extension
jamesnetherton opened a new pull request #905: Add Google Mail extension
URL: https://github.com/apache/camel-quarkus/pull/905
Fixes #807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #905:
Add Google Mail extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #905: Add Google Mail extension
URL: https://github.com/apache/camel-quarkus/pull/905#discussion_r394420040
##########
File path: integration-tests/google/src/main/resources/application.properties
##########
@@ -0,0 +1,25 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+# Quarkus
+quarkus.native.enable-https-url-handler=true
Review comment:
If this is required for the regular case to work, then I vote for doing it from within the extension via `new NativeImageSystemPropertyBuildItem("quarkus.ssl.native", "true)` so that the users do not need to bother.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #905: Add Google Mail extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #905: Add Google Mail extension
URL: https://github.com/apache/camel-quarkus/pull/905#discussion_r394423131
##########
File path: integration-tests/google/src/main/resources/application.properties
##########
@@ -0,0 +1,25 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+# Quarkus
+quarkus.native.enable-https-url-handler=true
Review comment:
Yep - let me do that :+1:
Actually, I think we can do likewise on a couple of other extensions. I'll check once we get this one merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton merged pull request #905: Add Google
Mail extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #905: Add Google Mail extension
URL: https://github.com/apache/camel-quarkus/pull/905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on issue #905: Add Google
Mail extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #905: Add Google Mail extension
URL: https://github.com/apache/camel-quarkus/pull/905#issuecomment-600701101
Latest changes remove the need for `quarkus.native.enable-https-url-handler` to be set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services