You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Albumen Kevin <al...@apache.org> on 2021/05/06 17:26:09 UTC
[VOTE] Release Apache Dubbo 2.7.11 RC1
Hello Community,
This is a call for vote to release Apache Dubbo version 2.7.11
The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.11/
The staging repo:
https://repository.apache.org/content/repositories/orgapachedubbo-1170/
Git tag for the release:
https://github.com/apache/dubbo/tree/dubbo-2.7.11
Hash for the release tag:
30616ea7fa945da7d76b703c2c2d29d123a6dfb0
Release Notes:
https://github.com/apache/dubbo/releases/tag/dubbo-2.7.11
The artifacts have been signed with Key 2B249EDD, which can be
found in the keys file:
https://dist.apache.org/repos/dist/dev/dubbo/KEYS
The vote will be open for at least 72 hours or until necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache Dubbo Team
Re:[VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by KimmKing <ki...@apache.org>.
+1
--
Kimm King(kimmking@apache.org/kimmking@163.com)
Apache Dubbo&ShardingSphere PMC Member
github&twitter: kimmking
At 2021-05-07 01:26:09, "Albumen Kevin" <al...@apache.org> wrote:
>Hello Community,
>
>This is a call for vote to release Apache Dubbo version 2.7.11
>
>The release candidates:
>https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.11/
>
>The staging repo:
>https://repository.apache.org/content/repositories/orgapachedubbo-1170/
>
>Git tag for the release:
>https://github.com/apache/dubbo/tree/dubbo-2.7.11
>
>Hash for the release tag:
>30616ea7fa945da7d76b703c2c2d29d123a6dfb0
>
>Release Notes:
>https://github.com/apache/dubbo/releases/tag/dubbo-2.7.11
>
>The artifacts have been signed with Key 2B249EDD, which can be
>found in the keys file:
>https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>The vote will be open for at least 72 hours or until necessary number of
>votes are reached.
>
>Please vote accordingly:
>
>[ ] +1 approve
>[ ] +0 no opinion
>[ ] -1 disapprove with the reason
>
>Thanks,
>The Apache Dubbo Team
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by YunKun Huang <ht...@gmail.com>.
oh, yes, you are right. then all good from my side.
On Fri, May 7, 2021 at 2:16 PM Albumen Kevin <al...@apache.org> wrote:
>
> Hi YunKun,
>
> dubbo-rpc-triple is the next generation rpc protocol which will be
> introduced in Dubbo 3.0.
> This release is still for Dubbo 2.7.x version. So we cannot find triple in
> staging repo.
>
> Albumen
>
>
> On Fri, May 7, 2021 at 11:26 AM YunKun Huang <ht...@gmail.com> wrote:
>
> > +1
> >
> > I have checked:
> >
> > + hash for release tag is correct
> > + Can compile from source code
> > + sha512 and asc is correct
> > + LICENSE NOTICE file exists
> > + Release notes looks good
> >
> > There is a mirror stuff, somehow I can't find dubbo-rpc-triple in
> > staging repo, but I can confirm we have it in previous release
> > (
> > https://repository.apache.org/content/repositories/releases/org/apache/dubbo/dubbo-rpc-triple/
> > )
> > Could you double check this?
> >
> > On Fri, May 7, 2021 at 1:26 AM Albumen Kevin <al...@apache.org> wrote:
> > >
> > > Hello Community,
> > >
> > > This is a call for vote to release Apache Dubbo version 2.7.11
> > >
> > > The release candidates:
> > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.11/
> > >
> > > The staging repo:
> > > https://repository.apache.org/content/repositories/orgapachedubbo-1170/
> > >
> > > Git tag for the release:
> > > https://github.com/apache/dubbo/tree/dubbo-2.7.11
> > >
> > > Hash for the release tag:
> > > 30616ea7fa945da7d76b703c2c2d29d123a6dfb0
> > >
> > > Release Notes:
> > > https://github.com/apache/dubbo/releases/tag/dubbo-2.7.11
> > >
> > > The artifacts have been signed with Key 2B249EDD, which can be
> > > found in the keys file:
> > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> > >
> > > The vote will be open for at least 72 hours or until necessary number of
> > > votes are reached.
> > >
> > > Please vote accordingly:
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thanks,
> > > The Apache Dubbo Team
> >
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by Albumen Kevin <al...@apache.org>.
Hi YunKun,
dubbo-rpc-triple is the next generation rpc protocol which will be
introduced in Dubbo 3.0.
This release is still for Dubbo 2.7.x version. So we cannot find triple in
staging repo.
Albumen
On Fri, May 7, 2021 at 11:26 AM YunKun Huang <ht...@gmail.com> wrote:
> +1
>
> I have checked:
>
> + hash for release tag is correct
> + Can compile from source code
> + sha512 and asc is correct
> + LICENSE NOTICE file exists
> + Release notes looks good
>
> There is a mirror stuff, somehow I can't find dubbo-rpc-triple in
> staging repo, but I can confirm we have it in previous release
> (
> https://repository.apache.org/content/repositories/releases/org/apache/dubbo/dubbo-rpc-triple/
> )
> Could you double check this?
>
> On Fri, May 7, 2021 at 1:26 AM Albumen Kevin <al...@apache.org> wrote:
> >
> > Hello Community,
> >
> > This is a call for vote to release Apache Dubbo version 2.7.11
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.11/
> >
> > The staging repo:
> > https://repository.apache.org/content/repositories/orgapachedubbo-1170/
> >
> > Git tag for the release:
> > https://github.com/apache/dubbo/tree/dubbo-2.7.11
> >
> > Hash for the release tag:
> > 30616ea7fa945da7d76b703c2c2d29d123a6dfb0
> >
> > Release Notes:
> > https://github.com/apache/dubbo/releases/tag/dubbo-2.7.11
> >
> > The artifacts have been signed with Key 2B249EDD, which can be
> > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo Team
>
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by YunKun Huang <ht...@gmail.com>.
+1
I have checked:
+ hash for release tag is correct
+ Can compile from source code
+ sha512 and asc is correct
+ LICENSE NOTICE file exists
+ Release notes looks good
There is a mirror stuff, somehow I can't find dubbo-rpc-triple in
staging repo, but I can confirm we have it in previous release
(https://repository.apache.org/content/repositories/releases/org/apache/dubbo/dubbo-rpc-triple/)
Could you double check this?
On Fri, May 7, 2021 at 1:26 AM Albumen Kevin <al...@apache.org> wrote:
>
> Hello Community,
>
> This is a call for vote to release Apache Dubbo version 2.7.11
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.11/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1170/
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.7.11
>
> Hash for the release tag:
> 30616ea7fa945da7d76b703c2c2d29d123a6dfb0
>
> Release Notes:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.11
>
> The artifacts have been signed with Key 2B249EDD, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by Albumen Kevin <al...@apache.org>.
OK, thanks!
I will think about it carefully. I have found the reason why thrift related
files were excluded when checking licenses while compiling and I will fix
the rest of the minor license and notice issues in the next release.
Albumen
On Mon, May 10, 2021 at 3:47 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> It might be better to use the local names so they can be found easily but
> I don't think it's a big deal. Either way is probably fine.
>
> Thanks,
> Justin
>
> On Mon, 10 May 2021, 5:21 pm Albumen Kevin, <al...@apache.org> wrote:
>
>> Hi, Justin
>>
>> > - LICENSE should also list InternalThreadLocal.java
>>
>> I have checked that InternalThreadLocal.java is learned from
>> `io.netty.util.concurrent.FastThreadLocal`[1] which has been declared in
>> the LICENSE file[2].
>>
>> There does not exist a file like
>> `io.netty.util.concurrent.InternalThreadLocal` in Netty.
>> And according to the LICENSE file we have declared the whole
>> `org.apache.dubbo.common.threadlocal` may contain a modified portion of
>> 'Netty'.
>> I think it may not be necessary for us to change anything in the LICENSE
>> file?
>>
>> [1]
>> https://github.com/apache/dubbo/blob/f29663bba655c9451b9db75b94d5cf945f0e7901/dubbo-common/src/main/java/org/apache/dubbo/common/threadlocal/InternalThreadLocal.java#L32
>> [2]
>> https://github.com/apache/dubbo/blob/f29663bba655c9451b9db75b94d5cf945f0e7901/LICENSE#L216
>> [3]
>> https://github.com/apache/dubbo/blob/f29663bba655c9451b9db75b94d5cf945f0e7901/LICENSE#L211
>>
>> Albumen
>>
>>
>> On Mon, May 10, 2021 at 11:32 AM Justin Mclean <ju...@classsoftware.com>
>> wrote:
>>
>>> Hi,
>>>
>>> +1 binding but there a couple of minor license and notice issues that
>>> need to be corrected.
>>>
>>> I checked:
>>> - signatures and hashes are fine
>>> - LICENSE should also list InternalThreadLocal.java
>>> - NOTICE doesn’t need to list information about protobuf as the project
>>> doesn’t have a NOTICE file
>>> - A few files are missing ASF headers, please add them e.g. [1]
>>> - No unexpected binary files
>>> - Can compile from source.
>>>
>>> Thanks,
>>> Justin
>>>
>>> 1. ./dubbo-rpc/dubbo-rpc-thrift/src/test/thrift/Demo.thrift
>>
>>
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by Albumen Kevin <al...@apache.org>.
Hi, Justin
> - LICENSE should also list InternalThreadLocal.java
I have checked that InternalThreadLocal.java is learned from
`io.netty.util.concurrent.FastThreadLocal`[1] which has been declared in
the LICENSE file[2].
There does not exist a file like
`io.netty.util.concurrent.InternalThreadLocal` in Netty.
And according to the LICENSE file we have declared the whole
`org.apache.dubbo.common.threadlocal` may contain a modified portion of
'Netty'.
I think it may not be necessary for us to change anything in the LICENSE
file?
[1]
https://github.com/apache/dubbo/blob/f29663bba655c9451b9db75b94d5cf945f0e7901/dubbo-common/src/main/java/org/apache/dubbo/common/threadlocal/InternalThreadLocal.java#L32
[2]
https://github.com/apache/dubbo/blob/f29663bba655c9451b9db75b94d5cf945f0e7901/LICENSE#L216
[3]
https://github.com/apache/dubbo/blob/f29663bba655c9451b9db75b94d5cf945f0e7901/LICENSE#L211
Albumen
On Mon, May 10, 2021 at 11:32 AM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> +1 binding but there a couple of minor license and notice issues that need
> to be corrected.
>
> I checked:
> - signatures and hashes are fine
> - LICENSE should also list InternalThreadLocal.java
> - NOTICE doesn’t need to list information about protobuf as the project
> doesn’t have a NOTICE file
> - A few files are missing ASF headers, please add them e.g. [1]
> - No unexpected binary files
> - Can compile from source.
>
> Thanks,
> Justin
>
> 1. ./dubbo-rpc/dubbo-rpc-thrift/src/test/thrift/Demo.thrift
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by Jun Liu <li...@apache.org>.
> - LICENSE should also list InternalThreadLocal.java
> - A few files are missing ASF headers, please add them e.g. [1]
Are these files excluded from the LICENSE format checking tool? How com we didn’t find them running CI.
Jun
> On May 10, 2021, at 11:31 AM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> +1 binding but there a couple of minor license and notice issues that need to be corrected.
>
> I checked:
> - signatures and hashes are fine
> - LICENSE should also list InternalThreadLocal.java
> - NOTICE doesn’t need to list information about protobuf as the project doesn’t have a NOTICE file
> - A few files are missing ASF headers, please add them e.g. [1]
> - No unexpected binary files
> - Can compile from source.
>
> Thanks,
> Justin
>
> 1. ./dubbo-rpc/dubbo-rpc-thrift/src/test/thrift/Demo.thrift
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I added the protobuf info in the NOTICE file several versions ago when adding gRPC support. I remember it clearly says in some place that a declaration must be included in a project's NOTICE file if there’s abt reference of the source code. I will check the protobuf codes later for sure.
See [1] (assuming it was under ALv2) or [2] if it was MIT/BSD licensed. Depending if it came from protobuf or grpc GitHub repos. In either case nothing should get added to NOTICE.
> I think we can fix it in the next release.
Sure.
Thanks,
Justin
1. https://infra.apache.org/licensing-howto.html#alv2-dep <https://infra.apache.org/licensing-howto.html#alv2-dep>
2. https://infra.apache.org/licensing-howto.html#permissive-deps <https://infra.apache.org/licensing-howto.html#permissive-deps>
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by Jun Liu <li...@apache.org>.
> - NOTICE doesn’t need to list information about protobuf as the project doesn’t have a NOTICE file
I added the protobuf info in the NOTICE file several versions ago when adding gRPC support. I remember it clearly says in some place that a declaration must be included in a project's NOTICE file if there’s abt reference of the source code. I will check the protobuf codes later for sure.
I think we can fix it in the next release.
Jun
> On May 10, 2021, at 11:31 AM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> +1 binding but there a couple of minor license and notice issues that need to be corrected.
>
> I checked:
> - signatures and hashes are fine
> - LICENSE should also list InternalThreadLocal.java
> - NOTICE doesn’t need to list information about protobuf as the project doesn’t have a NOTICE file
> - A few files are missing ASF headers, please add them e.g. [1]
> - No unexpected binary files
> - Can compile from source.
>
> Thanks,
> Justin
>
> 1. ./dubbo-rpc/dubbo-rpc-thrift/src/test/thrift/Demo.thrift
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 binding but there a couple of minor license and notice issues that need to be corrected.
I checked:
- signatures and hashes are fine
- LICENSE should also list InternalThreadLocal.java
- NOTICE doesn’t need to list information about protobuf as the project doesn’t have a NOTICE file
- A few files are missing ASF headers, please add them e.g. [1]
- No unexpected binary files
- Can compile from source.
Thanks,
Justin
1. ./dubbo-rpc/dubbo-rpc-thrift/src/test/thrift/Demo.thrift
Re: [VOTE] Release Apache Dubbo 2.7.11 RC1
Posted by Jun Liu <li...@apache.org>.
+1 binding
I have checked:
* Hash and signature are good
* LICENSE and NOTICE exist
* All unit tests passed on my Mac with JDK1.8
* Release notes are fine
One suggestion,
I think we have put too many details in the Release Notes by simply listing all the merged issues or PRs. I would prefer a summarized brief list that highlights the important features or bugfixes. For those who care about the details for some specific reasons can check the commits or being redirected to another page that we’ve prepared with all the details.
Jun
> On May 7, 2021, at 1:26 AM, Albumen Kevin <al...@apache.org> wrote:
>
> Hello Community,
>
> This is a call for vote to release Apache Dubbo version 2.7.11
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.11/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1170/
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.7.11
>
> Hash for the release tag:
> 30616ea7fa945da7d76b703c2c2d29d123a6dfb0
>
> Release Notes:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.11
>
> The artifacts have been signed with Key 2B249EDD, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team