You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/09/01 10:28:05 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2451: Minor cmake cleanup
emmenlau opened a new pull request #2451:
URL: https://github.com/apache/thrift/pull/2451
This PR makes some changes to the cmake C++ build:
- When available, it will prefer the OpenSSL targets `OpenSSL::OpenSSL` and `OpenSSL::Crypto` over the older libraries variable.
- It removes the use of a number of cmake macros that have basically no effect (instead they obscure what will happen), like `TARGET_INCLUDE_DIRECTORIES_THRIFT`, `TARGET_LINK_LIBRARIES_THRIFT`, `LINK_AGAINST_THRIFT_LIBRARY` and `TARGET_LINK_LIBRARIES_THRIFT_AGAINST_THRIFT_LIBRARY`.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2451: Minor cmake cleanup
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2451:
URL: https://github.com/apache/thrift/pull/2451#issuecomment-911602668
Build errors on Travis are unrelated. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau merged pull request #2451: Minor cmake cleanup
Posted by GitBox <gi...@apache.org>.
emmenlau merged pull request #2451:
URL: https://github.com/apache/thrift/pull/2451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org