You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Dejan Stojadinović (Jira)" <ji...@apache.org> on 2023/02/16 20:10:00 UTC
[jira] [Updated] (KAFKA-14728) Remove 'spotlessScalaCheck' task (out of Jenkinsfile)
[ https://issues.apache.org/jira/browse/KAFKA-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dejan Stojadinović updated KAFKA-14728:
---------------------------------------
Description:
*Note*: this ticket blocks Gradle major version upgrade (_*7 -->> 8*_): KAFKA-14680
*Rationale:*
* build works fine in trunk with Gradle 7.6 and spotless gradle plugin 6.13.0 for all currently used JDK versions (that is: JDK 8 / JDK 11 / JDK 17)
* however, recent spotless gradle plugin versions (6.14.\+) support only JDK 11\+ versions: https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#6140---2023-01-26
* at the moment Kafka build powered by Gradle 8.0 breaks when combined with all relevant spotless gradle plugin versions (from 6.13.0 to 6.15.0); _github issue is created [here|https://github.com/diffplug/spotless/issues/1572]_
* given a fact that Kafka still needs to support JDK 8 builds (until Kafka version 4.0) it is reasonable to simply remove spotless checks out of Jenkinsfile (and re-introduce them when the time comes).
For even more details see GitHub discussion here: https://github.com/apache/kafka/pull/13205#issuecomment-1431575644
Note: spotless plugin configuration in build.gradle is out of this ticket scope.
was:
*Note*: this ticket blocks Gradle major version upgrade (_*7 -->> 8*_): KAFKA-14680
*Rationale:*
* build works fine in trunk with Gradle 7.6 and spotless gradle plugin 6.13.0 for all currently used JDK versions (that is: JDK 8 / JDK 11 / JDK 17)
* however, recent spotless gradle plugin versions (6.14.\+) support only JDK 11\+ versions: https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#6140---2023-01-26
* given a fact that Kafka still needs to support JDK 8 builds (until Kafka version 4.0) it is reasonable to simply remove spotless checks out of Jenkinsfile (and re-introduce them when the time comes).
For even more details see GitHub discussion here: https://github.com/apache/kafka/pull/13205#issuecomment-1431575644
Note: spotless plugin configuration in build.gradle is out of this ticket scope.
> Remove 'spotlessScalaCheck' task (out of Jenkinsfile)
> -----------------------------------------------------
>
> Key: KAFKA-14728
> URL: https://issues.apache.org/jira/browse/KAFKA-14728
> Project: Kafka
> Issue Type: Improvement
> Components: build
> Reporter: Dejan Stojadinović
> Assignee: Dejan Stojadinović
> Priority: Major
>
> *Note*: this ticket blocks Gradle major version upgrade (_*7 -->> 8*_): KAFKA-14680
> *Rationale:*
> * build works fine in trunk with Gradle 7.6 and spotless gradle plugin 6.13.0 for all currently used JDK versions (that is: JDK 8 / JDK 11 / JDK 17)
> * however, recent spotless gradle plugin versions (6.14.\+) support only JDK 11\+ versions: https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#6140---2023-01-26
> * at the moment Kafka build powered by Gradle 8.0 breaks when combined with all relevant spotless gradle plugin versions (from 6.13.0 to 6.15.0); _github issue is created [here|https://github.com/diffplug/spotless/issues/1572]_
> * given a fact that Kafka still needs to support JDK 8 builds (until Kafka version 4.0) it is reasonable to simply remove spotless checks out of Jenkinsfile (and re-introduce them when the time comes).
> For even more details see GitHub discussion here: https://github.com/apache/kafka/pull/13205#issuecomment-1431575644
> Note: spotless plugin configuration in build.gradle is out of this ticket scope.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)