You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/20 10:20:29 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3902: vrouter:
Save PlaceHolder nic for VR if network does not have source nat
ustcweizhou opened a new pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902
## Description
<!--- Describe your changes in detail -->
This PR aims to fix the issue below
1. Create a network offering for isolated network, services: Dns/Dhcp/Userdata, and enable it
2. create a isolated network with the new offering
3. create a vm
4. check the guest IP of virtual router,
5. restart network with cleanup
6. check the guest IP of new virtual router
7. The IP in step4 and step6 should be the same, but they are different actually.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
tested with steps above, the IPs are same in step 7.
change network to another offering with public ip, the placeholder ip is removed from database.
tested with shared networks and L2 network as well.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-595624970
@ustcweizhou there seems to be some new errors, can you check? Meanwhile I'll rekick another test round.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-594247681
<b>Trillian test result (tid-1174)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59464 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3902-t1174-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 176.91 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 173.19 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 231.17 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.02 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.39 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.36 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.38 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.37 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.17 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.24 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 16.54 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.24 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 73.92 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.17 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.54 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.79 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598614902
<b>Trillian test result (tid-1238)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59003 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3902-t1238-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 190.81 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 174.23 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 239.50 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.16 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.02 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.34 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.33 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.33 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 66.22 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.22 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.25 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.88 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.30 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 73.88 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.20 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.73 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.51 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-593816023
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-592415164
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-592428995
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-593810353
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-594358690
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-589544815
> another 4.13 milestone PR, @weizhouapache ?
@DaanHoogland we will create more PRs in next months.
for non-blocker issues, they can be added to 4.13.2.0, instead of 4.13.1.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598633981
@weizhouapache is this issue/bug visible only when no sourceNat on the network?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598213530
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-596472046
@weizhouapache @andrijapanic-dont-use-this-one @rhtyd If this is not fixed by friday, is it save to move to 4.13.2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-593815880
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-596473025
@DaanHoogland no problem for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598270942
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-594546288
<b>Trillian test result (tid-1182)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24557 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3902-t1182-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 176.19 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 172.05 | test_privategw_acl.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 200.19 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Failure` | 198.98 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 125.37 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 85.93 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 169.31 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 195.32 | test_vpc_redundant.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598270740
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache closed pull request #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3902: vrouter:
Save PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
ustcweizhou opened a new pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902
## Description
<!--- Describe your changes in detail -->
This PR aims to fix the issue below
1. Create a network offering for isolated network, services: Dns/Dhcp/Userdata, and enable it
2. create a isolated network with the new offering
3. create a vm
4. check the guest IP of virtual router,
5. restart network with cleanup
6. check the guest IP of new virtual router
7. The IP in step4 and step6 should be the same, but they are different actually.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
tested with steps above, the IPs are same in step 7.
change network to another offering with public ip, the placeholder ip is removed from database.
tested with shared networks and L2 network as well.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-597576347
@DaanHoogland can you re-kick a test ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-593793402
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3902: vrouter:
Save PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
ustcweizhou opened a new pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902
## Description
<!--- Describe your changes in detail -->
This PR aims to fix the issue below
1. Create a network offering for isolated network, services: Dns/Dhcp/Userdata, and enable it
2. create a isolated network with the new offering
3. create a vm
4. check the guest IP of virtual router,
5. restart network with cleanup
6. check the guest IP of new virtual router
7. The IP in step4 and step6 should be the same, but they are different actually.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
tested with steps above, the IPs are same in step 7.
change network to another offering with public ip, the placeholder ip is removed from database.
tested with shared networks and L2 network as well.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-597586107
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-597854631
<b>Trillian test result (tid-1229)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29767 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3902-t1229-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 223.51 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 219.65 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 330.52 | test_privategw_acl.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 257.25 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Failure` | 270.42 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 167.91 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 130.54 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 229.16 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 256.05 | test_vpc_redundant.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598203512
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-592423526
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3902:
vrouter: Save PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-594247681
<b>Trillian test result (tid-1174)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59464 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3902-t1174-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 176.91 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 173.19 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 231.17 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.02 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.39 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.36 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.38 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.37 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.17 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.24 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 16.54 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.24 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 73.92 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.17 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.54 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.79 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-594358653
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598866950
This one needs more love, and since we are few h away from code freeze, moving it to 4.13.2 milestone.
Hope that is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-593793578
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-597585779
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-589291529
another 4.13 milestone PR, @weizhouapache ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3902: vrouter:
Save PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
ustcweizhou opened a new pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902
## Description
<!--- Describe your changes in detail -->
This PR aims to fix the issue below
1. Create a network offering for isolated network, services: Dns/Dhcp/Userdata, and enable it
2. create a isolated network with the new offering
3. create a vm
4. check the guest IP of virtual router,
5. restart network with cleanup
6. check the guest IP of new virtual router
7. The IP in step4 and step6 should be the same, but they are different actually.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
tested with steps above, the IPs are same in step 7.
change network to another offering with public ip, the placeholder ip is removed from database.
tested with shared networks and L2 network as well.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598203119
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-595625181
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-592428586
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
ustcweizhou commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-588910323
@rhtyd sorry created more PRs today.
Rakesh ( @ravening ) will create some PRs for VR/network issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache closed pull request #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache closed pull request #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-592609473
<b>Trillian test result (tid-1148)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25967 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3902-t1148-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 74 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 178.37 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 179.19 | test_privategw_acl.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 213.53 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Failure` | 221.76 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 130.60 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 92.29 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 183.46 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 209.31 | test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 241.25 | test_vpc_vpn.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-592415054
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3902: vrouter: Save
PlaceHolder nic for VR if network does not have source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-598637874
> @weizhouapache is this issue/bug visible only when no sourceNat on the network?
@andrijapanicsb yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services