[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover
URL: https://github.com/apache/drill/pull/1878#discussion_r336972303
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderOverflow.java
 ##########
 @@ -59,55 +61,64 @@
 
   @Test
   public void testVectorSizeLimit() {
-    TupleMetadata schema = new SchemaBuilder()
+    final TupleMetadata schema = new SchemaBuilder()
 
 Review comment:
   Since Java supports effective final there is no need to excessive use of final keyword unless s you want to explicitly indicate that variable is final. I am not going to request the change during code review, I guess this mostly relates to the developers code writing style but since you are making lots of refactoring adding final keyword, just wanted to highlight that this is might be unnecessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services