You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/02/07 14:57:32 UTC
Review Request 43302: Libprocess: Introduced Hooks and Options for
Subprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/subprocess.hpp bb50cc3070245a294fa16efe44f14ae893bc5518
3rdparty/libprocess/src/subprocess.cpp ff477e37a9619c780bddd5a8e629fa981b729715
Diff: https://reviews.apache.org/r/43302/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 43302: Libprocess: Introduced Hooks and Options for
Subprocess.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 160
> > <https://reviews.apache.org/r/43302/diff/1/?file=1237067#file1237067line160>
> >
> > Why we not use `const` instead of `constexpr` here?
Because a parameter to a template specialization must be a `constexpr`.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118215
-----------------------------------------------------------
On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 1:57 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp bb50cc3070245a294fa16efe44f14ae893bc5518
> 3rdparty/libprocess/src/subprocess.cpp ff477e37a9619c780bddd5a8e629fa981b729715
>
> Diff: https://reviews.apache.org/r/43302/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 43302: Libprocess: Introduced Hooks and Options for
Subprocess.
Posted by haosdent huang <ha...@gmail.com>.
> On Feb. 8, 2016, 11:13 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/include/process/subprocess.hpp, line 160
> > <https://reviews.apache.org/r/43302/diff/1/?file=1237067#file1237067line160>
> >
> > Why we not use `const` instead of `constexpr` here?
>
> Joris Van Remoortere wrote:
> Because a parameter to a template specialization must be a `constexpr`.
got it, thank you very much for your explanation.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118215
-----------------------------------------------------------
On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 1:57 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp bb50cc3070245a294fa16efe44f14ae893bc5518
> 3rdparty/libprocess/src/subprocess.cpp ff477e37a9619c780bddd5a8e629fa981b729715
>
> Diff: https://reviews.apache.org/r/43302/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 43302: Libprocess: Introduced Hooks and Options for
Subprocess.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118215
-----------------------------------------------------------
3rdparty/libprocess/include/process/subprocess.hpp (line 160)
<https://reviews.apache.org/r/43302/#comment179432>
Why we not use `const` instead of `constexpr` here?
- haosdent huang
On Feb. 7, 2016, 1:57 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 1:57 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp bb50cc3070245a294fa16efe44f14ae893bc5518
> 3rdparty/libprocess/src/subprocess.cpp ff477e37a9619c780bddd5a8e629fa981b729715
>
> Diff: https://reviews.apache.org/r/43302/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 43302: Libprocess: Introduced Hooks for Subprocess.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 4:48 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Bugs: MESOS-4636
https://issues.apache.org/jira/browse/MESOS-4636
Repository: mesos
Description (updated)
-------
Libprocess: Introduced Hooks for Subprocess.
Diffs (updated)
-----
3rdparty/libprocess/include/process/subprocess.hpp bb50cc3070245a294fa16efe44f14ae893bc5518
3rdparty/libprocess/src/subprocess.cpp ff477e37a9619c780bddd5a8e629fa981b729715
Diff: https://reviews.apache.org/r/43302/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 43302: Libprocess: Introduced Hooks for Subprocess.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/#review118567
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/include/process/subprocess.hpp (line 163)
<https://reviews.apache.org/r/43302/#comment179838>
Do you need the typedef?
- Benjamin Hindman
On Feb. 9, 2016, 7:12 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43302/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 7:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp bb50cc3070245a294fa16efe44f14ae893bc5518
> 3rdparty/libprocess/src/subprocess.cpp ff477e37a9619c780bddd5a8e629fa981b729715
>
> Diff: https://reviews.apache.org/r/43302/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 43302: Libprocess: Introduced Hooks for Subprocess.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43302/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 7:12 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Summary (updated)
-----------------
Libprocess: Introduced Hooks for Subprocess.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/subprocess.hpp bb50cc3070245a294fa16efe44f14ae893bc5518
3rdparty/libprocess/src/subprocess.cpp ff477e37a9619c780bddd5a8e629fa981b729715
Diff: https://reviews.apache.org/r/43302/diff/
Testing
-------
Thanks,
Joris Van Remoortere