You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/04/24 10:59:57 UTC
[GitHub] [incubator-tubemq] aloyszhang commented on a change in pull request #64: [TUBEMQ-81] Fix LogClearRunner bug && format BrokerDefMetadata
aloyszhang commented on a change in pull request #64:
URL: https://github.com/apache/incubator-tubemq/pull/64#discussion_r414484186
##########
File path: tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStoreManager.java
##########
@@ -703,7 +703,7 @@ public void run() {
.append(tubeConfig.getLogClearupDurationMs()).toString());
sBuilder.delete(0, sBuilder.length());
}
- if (!expiredTopic.isEmpty()) {
+ if (expiredTopic.isEmpty()) {
Review comment:
Print log here indicates that some expired file has been deleted, so I think we cann't make this change .
##########
File path: tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStoreManager.java
##########
@@ -703,7 +703,7 @@ public void run() {
.append(tubeConfig.getLogClearupDurationMs()).toString());
sBuilder.delete(0, sBuilder.length());
}
- if (!expiredTopic.isEmpty()) {
+ if (expiredTopic.isEmpty()) {
Review comment:
Maybe move this log print to [the end of the loop of file delete](https://github.com/apache/incubator-tubemq/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStoreManager.java#L697)
##########
File path: tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStoreManager.java
##########
@@ -703,7 +703,7 @@ public void run() {
.append(tubeConfig.getLogClearupDurationMs()).toString());
sBuilder.delete(0, sBuilder.length());
}
- if (!expiredTopic.isEmpty()) {
+ if (expiredTopic.isEmpty()) {
Review comment:
Mabye move this log print to [the end of file delete loop](https://github.com/apache/incubator-tubemq/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStoreManager.java#L697) is better.
##########
File path: tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStoreManager.java
##########
@@ -703,7 +703,7 @@ public void run() {
.append(tubeConfig.getLogClearupDurationMs()).toString());
sBuilder.delete(0, sBuilder.length());
}
- if (!expiredTopic.isEmpty()) {
+ if (expiredTopic.isEmpty()) {
Review comment:
Maybe move this log print to [the end of the loop of file delete](https://github.com/apache/incubator-tubemq/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStoreManager.java#L697)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org