[GitHub] [hudi] danny0405 commented on pull request #8088: [HUDI-5873] The pending compactions of dataset table should not block…

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on PR #8088:
URL: https://github.com/apache/hudi/pull/8088#issuecomment-1459253998

   Thanks for the reminder, I went through the code and there seems two checking logic for the flag `wasSynced`:
   
   1. the instant we want to rollback should still be includede in the active timeline
   2. or the instant time should be smaller than or equals to the latest compaction instant of the MDT
   
   But let's address this case specifically, in this patch, I lossen the restriction to unlock the restriction that the inflight compaction can block the compaction of MDT. It does not break the rule of 1 and 2 because the instant consided to be compacted should already be consider committed/complete on the DT, which means it would never be rolled back.
   
   If the instant was never considered to be rolled back, then things ganna be okay right?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org