You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/09/09 16:30:18 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4803: Csv reader improved benchmarks
tustvold opened a new pull request, #4803:
URL: https://github.com/apache/arrow-rs/pull/4803
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
As we look to make changes to both the CSV reader itself (#4795) and the way that values are parsed (#4785) having good benchmark coverage is really important. Whilst reviewing #4795 I noticed an oversight in the benchmarks I added in #3357. In particular the parsers are tested with values sampled from the entire range of primitives. It is fairly common for CSVs to contain primitives on the order of thousands, not trillions, and so we should have benchmark coverage for this case.
On my local machine we can see the difference this makes
```
4096 i32_small(0) - 4096
time: [78.292 µs 78.340 µs 78.390 µs]
4096 i32(0) - 4096 time: [137.50 µs 137.95 µs 138.39 µs]
4096 u64_small(0) - 4096
time: [81.071 µs 81.153 µs 81.244 µs]
4096 u64(0) - 4096 time: [146.21 µs 146.36 µs 146.51 µs]
4096 i64_small(0) - 4096
time: [101.31 µs 101.44 µs 101.59 µs]
4096 i64(0) - 4096 time: [162.49 µs 163.03 µs 163.63 µs]
4096 f32_small(0) - 4096
time: [128.87 µs 129.04 µs 129.18 µs]
4096 f32(0) - 4096 time: [157.81 µs 157.88 µs 157.95 µs]
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4803: Improve CSV Reader Benchmark Coverage of Small Primitives
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4803:
URL: https://github.com/apache/arrow-rs/pull/4803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org