You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "jnioche (via GitHub)" <gi...@apache.org> on 2024/02/22 11:59:48 UTC

[PR] [STORM-4030] Dependency upgrades (storm)

jnioche opened a new pull request, #3626:
URL: https://github.com/apache/storm/pull/3626

   ## What is the purpose of the change
   
   Update dependencies
   
   ## How was the change tested
   
   `mvn clean test` ran successfully


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-4030] Dependency upgrades (storm)

Posted by "jnioche (via GitHub)" <gi...@apache.org>.
jnioche merged PR #3626:
URL: https://github.com/apache/storm/pull/3626


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-4030] Dependency upgrades (storm)

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3626:
URL: https://github.com/apache/storm/pull/3626#issuecomment-1959603586

   awesome


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-4030] Dependency upgrades (storm)

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #3626:
URL: https://github.com/apache/storm/pull/3626#discussion_r1499138646


##########
pom.xml:
##########
@@ -97,31 +97,31 @@
         <jetty.version>9.4.53.v20231009</jetty.version>
         <clojure.tools.logging.version>0.2.3</clojure.tools.logging.version>
         <carbonite.version>1.6.0</carbonite.version>
-        <snakeyaml.version>2.0</snakeyaml.version>
+        <snakeyaml.version>2.2</snakeyaml.version>
         <httpclient.version>4.5.14</httpclient.version>
         <httpclient.core.version>4.4.16</httpclient.core.version>
         <jctools.version>2.0.1</jctools.version>
         <jgrapht.version>0.9.0</jgrapht.version>
-        <guava.version>32.1.3-jre</guava.version>
+        <guava.version>33.0.0-jre</guava.version>
         <auto-service.version>1.0-rc4</auto-service.version>
-        <netty.version>4.1.100.Final</netty.version>
+        <netty.version>4.1.107.Final</netty.version>
         <sysout-over-slf4j.version>1.0.2</sysout-over-slf4j.version>
-        <log4j.version>2.21.1</log4j.version>
-        <slf4j.version>1.7.36</slf4j.version>
+        <log4j.version>2.23.0</log4j.version>
+        <slf4j.version>2.0.12</slf4j.version>
         <metrics.version>3.2.6</metrics.version>
         <mockito.version>4.11.0</mockito.version>
         <zookeeper.version>3.9.1</zookeeper.version>
         <snappy.version>1.1.10.4</snappy.version>
         <jline.version>0.9.94</jline.version>
         <hive.version>3.1.3</hive.version>
-        <hadoop.version>3.3.6</hadoop.version>
+        <hadoop.version>3.4.0</hadoop.version>

Review Comment:
   Looks like `3.4.0` purged `hadoop-auth` ? Isn't listed in https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-auth anymore, so might be gone and needs migration?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-4030] Dependency upgrades (storm)

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #3626:
URL: https://github.com/apache/storm/pull/3626#discussion_r1499139290


##########
pom.xml:
##########
@@ -97,31 +97,31 @@
         <jetty.version>9.4.53.v20231009</jetty.version>
         <clojure.tools.logging.version>0.2.3</clojure.tools.logging.version>
         <carbonite.version>1.6.0</carbonite.version>
-        <snakeyaml.version>2.0</snakeyaml.version>
+        <snakeyaml.version>2.2</snakeyaml.version>
         <httpclient.version>4.5.14</httpclient.version>
         <httpclient.core.version>4.4.16</httpclient.core.version>
         <jctools.version>2.0.1</jctools.version>
         <jgrapht.version>0.9.0</jgrapht.version>
-        <guava.version>32.1.3-jre</guava.version>
+        <guava.version>33.0.0-jre</guava.version>
         <auto-service.version>1.0-rc4</auto-service.version>
-        <netty.version>4.1.100.Final</netty.version>
+        <netty.version>4.1.107.Final</netty.version>
         <sysout-over-slf4j.version>1.0.2</sysout-over-slf4j.version>
-        <log4j.version>2.21.1</log4j.version>
-        <slf4j.version>1.7.36</slf4j.version>
+        <log4j.version>2.23.0</log4j.version>
+        <slf4j.version>2.0.12</slf4j.version>

Review Comment:
   slf4j -> slf4j2 might require some changes in the log4j2 bindings used as the way the static logger bindings are loaded has changed in slf4j2. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-4030] Dependency upgrades (storm)

Posted by "jnioche (via GitHub)" <gi...@apache.org>.
jnioche commented on code in PR #3626:
URL: https://github.com/apache/storm/pull/3626#discussion_r1499148766


##########
pom.xml:
##########
@@ -97,31 +97,31 @@
         <jetty.version>9.4.53.v20231009</jetty.version>
         <clojure.tools.logging.version>0.2.3</clojure.tools.logging.version>
         <carbonite.version>1.6.0</carbonite.version>
-        <snakeyaml.version>2.0</snakeyaml.version>
+        <snakeyaml.version>2.2</snakeyaml.version>
         <httpclient.version>4.5.14</httpclient.version>
         <httpclient.core.version>4.4.16</httpclient.core.version>
         <jctools.version>2.0.1</jctools.version>
         <jgrapht.version>0.9.0</jgrapht.version>
-        <guava.version>32.1.3-jre</guava.version>
+        <guava.version>33.0.0-jre</guava.version>
         <auto-service.version>1.0-rc4</auto-service.version>
-        <netty.version>4.1.100.Final</netty.version>
+        <netty.version>4.1.107.Final</netty.version>
         <sysout-over-slf4j.version>1.0.2</sysout-over-slf4j.version>
-        <log4j.version>2.21.1</log4j.version>
-        <slf4j.version>1.7.36</slf4j.version>
+        <log4j.version>2.23.0</log4j.version>
+        <slf4j.version>2.0.12</slf4j.version>
         <metrics.version>3.2.6</metrics.version>
         <mockito.version>4.11.0</mockito.version>
         <zookeeper.version>3.9.1</zookeeper.version>
         <snappy.version>1.1.10.4</snappy.version>
         <jline.version>0.9.94</jline.version>
         <hive.version>3.1.3</hive.version>
-        <hadoop.version>3.3.6</hadoop.version>
+        <hadoop.version>3.4.0</hadoop.version>

Review Comment:
   looks like it is still at the RC level
   https://github.com/apache/hadoop/tags



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-4030] Dependency upgrades (storm)

Posted by "jnioche (via GitHub)" <gi...@apache.org>.
jnioche commented on code in PR #3626:
URL: https://github.com/apache/storm/pull/3626#discussion_r1499147592


##########
pom.xml:
##########
@@ -97,31 +97,31 @@
         <jetty.version>9.4.53.v20231009</jetty.version>
         <clojure.tools.logging.version>0.2.3</clojure.tools.logging.version>
         <carbonite.version>1.6.0</carbonite.version>
-        <snakeyaml.version>2.0</snakeyaml.version>
+        <snakeyaml.version>2.2</snakeyaml.version>
         <httpclient.version>4.5.14</httpclient.version>
         <httpclient.core.version>4.4.16</httpclient.core.version>
         <jctools.version>2.0.1</jctools.version>
         <jgrapht.version>0.9.0</jgrapht.version>
-        <guava.version>32.1.3-jre</guava.version>
+        <guava.version>33.0.0-jre</guava.version>
         <auto-service.version>1.0-rc4</auto-service.version>
-        <netty.version>4.1.100.Final</netty.version>
+        <netty.version>4.1.107.Final</netty.version>
         <sysout-over-slf4j.version>1.0.2</sysout-over-slf4j.version>
-        <log4j.version>2.21.1</log4j.version>
-        <slf4j.version>1.7.36</slf4j.version>
+        <log4j.version>2.23.0</log4j.version>
+        <slf4j.version>2.0.12</slf4j.version>
         <metrics.version>3.2.6</metrics.version>
         <mockito.version>4.11.0</mockito.version>
         <zookeeper.version>3.9.1</zookeeper.version>
         <snappy.version>1.1.10.4</snappy.version>
         <jline.version>0.9.94</jline.version>
         <hive.version>3.1.3</hive.version>
-        <hadoop.version>3.3.6</hadoop.version>
+        <hadoop.version>3.4.0</hadoop.version>

Review Comment:
   The changes for 3.4.0 are not documented on https://hadoop.apache.org/docs/stable/ 
   Will revert for now, we can work out whether hadoop-auth is needed later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [STORM-4030] Dependency upgrades (storm)

Posted by "jnioche (via GitHub)" <gi...@apache.org>.
jnioche commented on PR #3626:
URL: https://github.com/apache/storm/pull/3626#issuecomment-1959602138

   > Can we document the updated versions in the related Jira? Otherwise, it might be difficult for consumers to actually see the diff in the next release.
   
   done, see https://issues.apache.org/jira/browse/STORM-4030


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org