[jira] [Commented] (CASSANDRA-14742) Race Condition in batchlog replica collection

["Alex Petrov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-14742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617589#comment-16617589 ] 

Alex Petrov commented on CASSANDRA-14742:
-----------------------------------------

We're picking batchlog CL of {{ONE}} or {{TWO}} since the logic in {{BatchlogManager#EndpointFilter}} allows either one node (local, in case of single-node data centers), or two replicas from different racks.

> Race Condition in batchlog replica collection
> ---------------------------------------------
>
>                 Key: CASSANDRA-14742
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14742
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Alex Petrov
>            Assignee: Alex Petrov
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When we collect nodes for it in {{StorageProxy#getBatchlogReplicas}}, we already filter out down replicas; subsequently they get picked up and taken for liveAndDown.
> There's a possible race condition due to picking tokens from token metadata twice (once in {{StorageProxy#getBatchlogReplicas}} and second one in {{ReplicaPlan#forBatchlogWrite}})



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org