You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/06/14 00:07:49 UTC
Re: Review Request 65976: Allowed profiles to be missing from
`DiskProfileAdaptor`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65976/
-----------------------------------------------------------
(Updated June 14, 2018, 12:07 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-8825
https://issues.apache.org/jira/browse/MESOS-8825
Repository: mesos
Description
-------
Allowed profiles to be missing from `DiskProfileAdaptor`.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb
src/resource_provider/storage/uri_disk_profile_adaptor.cpp 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7
Diff: https://reviews.apache.org/r/65976/diff/4/
Changes: https://reviews.apache.org/r/65976/diff/3-4/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65976: Allowed profiles to be missing from
`DiskProfileAdaptor`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65976/#review204997
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On June 18, 2018, 8:31 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65976/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 8:31 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8825
> https://issues.apache.org/jira/browse/MESOS-8825
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allowed profiles to be missing from `DiskProfileAdaptor`.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7
>
>
> Diff: https://reviews.apache.org/r/65976/diff/5/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65976: Made SLRP be able to handle disappeared
profiles.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65976/
-----------------------------------------------------------
(Updated June 20, 2018, 4:35 a.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Fixed a bug where the missing profiles are not removed. Also moved changes related to `UriDiskProfileAdaptor` into the next patch.
Summary (updated)
-----------------
Made SLRP be able to handle disappeared profiles.
Bugs: MESOS-8825
https://issues.apache.org/jira/browse/MESOS-8825
Repository: mesos
Description (updated)
-------
When profile disappears, SLRP will remove it from its profile metadata.
Since we maintain an invariant that profiles of all accepted operations
must exist, the assertions related to profile existence remain true.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb
Diff: https://reviews.apache.org/r/65976/diff/6/
Changes: https://reviews.apache.org/r/65976/diff/5-6/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 65976: Allowed profiles to be missing from
`DiskProfileAdaptor`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65976/
-----------------------------------------------------------
(Updated June 18, 2018, 6:31 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Added the checks back as suggested by Benjamin.
Bugs: MESOS-8825
https://issues.apache.org/jira/browse/MESOS-8825
Repository: mesos
Description
-------
Allowed profiles to be missing from `DiskProfileAdaptor`.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb
src/resource_provider/storage/uri_disk_profile_adaptor.cpp 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7
Diff: https://reviews.apache.org/r/65976/diff/5/
Changes: https://reviews.apache.org/r/65976/diff/4-5/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao