You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:54:20 UTC

[GitHub] [apisix-dashboard] membphis opened a new issue #671: feat: use Lua's `__index` to mock all of the share dict

membphis opened a new issue #671:
URL: https://github.com/apache/apisix-dashboard/issues/671


   - Why do you submit this issue?
   - [x] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   original comment: https://github.com/apache/apisix-dashboard/pull/651/files#r516339002
   ___
   ### Requirements or improvement
   - Please describe your requirements or improvement suggestions.
   
   `__index` can mock all of the share dicts, even we can use it to mock all of the API in `ngx`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen closed issue #671: feat: use Lua's `__index` to mock all of the share dict

Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #671:
URL: https://github.com/apache/apisix-dashboard/issues/671


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #671: feat: use Lua's `__index` to mock all of the share dict

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #671:
URL: https://github.com/apache/apisix-dashboard/issues/671#issuecomment-757828309


   @nic-chen Please remove any related text from this repo if needed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on issue #671: feat: use Lua's `__index` to mock all of the share dict

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #671:
URL: https://github.com/apache/apisix-dashboard/issues/671#issuecomment-756600462


   Please assign it to me. I will improve the schema-sync.lua.
   
   Releated: https://github.com/apache/apisix-dashboard/issues/1237.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on issue #671: feat: use Lua's `__index` to mock all of the share dict

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #671:
URL: https://github.com/apache/apisix-dashboard/issues/671#issuecomment-757811432


   we don't need the tool `schema-sync` now, we could use [APISIX controlAPI](https://github.com/apache/apisix/blob/master/doc/control-api.md#get-v1schema) to export schema. 
   we only need to update doc about sync schema here.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on issue #671: feat: use Lua's `__index` to mock all of the share dict

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #671:
URL: https://github.com/apache/apisix-dashboard/issues/671#issuecomment-757851568


   > @nic-chen Please remove any related text from this repo if needed
   
   sure, we will update the doc, and track it in #1237 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #671: feat: use Lua's `__index` to mock all of the share dict

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #671:
URL: https://github.com/apache/apisix-dashboard/issues/671#issuecomment-753731082


   done?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #671: feat: use Lua's `__index` to mock all of the share dict

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #671:
URL: https://github.com/apache/apisix-dashboard/issues/671#issuecomment-756586438


   cc @starsz 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on issue #671: feat: use Lua's `__index` to mock all of the share dict

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #671:
URL: https://github.com/apache/apisix-dashboard/issues/671#issuecomment-757812143


   it's same with #1237 , we could close this now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org