You are viewing a plain text version of this content. The canonical link for it is here.
Posted to custos@airavata.apache.org by GitBox <gi...@apache.org> on 2021/07/09 22:37:49 UTC
[GitHub] [airavata-custos-portal] sannidhi09 opened a new pull request #105: Developed front end support to create child entities.
sannidhi09 opened a new pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105
Developed front-end support to create child entities and to view them as a 1-level tree structures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668767923
##########
File path: src/lib/components/overlay/table-overlay-body.vue
##########
@@ -0,0 +1,143 @@
+<template>
Review comment:
We are using the `overlay-table`, so the child of this will inherit property. That's why I have created under same root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] dinukadesilva commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
dinukadesilva commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r669210991
##########
File path: src/lib/components/pages/TenantEntities.vue
##########
@@ -89,7 +63,12 @@ export default {
return this.$route.params.clientId;
},
entities() {
- return this.$store.getters["entity/getEntities"]({clientId: this.clientId, ownerId: this.currentUsername})
Review comment:
You could use "allEntities" here
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type, ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
Krishna. The concern is that EMC portal need to have this return even though it's not relevant to custos portal much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668229473
##########
File path: .env
##########
@@ -1,3 +1,3 @@
-VUE_APP_CLIENT_ID="custos-su8y67qnckn5eejwusnz-10000641"
-VUE_APP_CLIENT_SEC="wGo5SGduOofjqFpl3UrR8ngrTafGHMOQDInz3bF0"
+VUE_APP_CLIENT_ID="custos-6nwoqodstpe5mvcq09lh-10000101"
Review comment:
Got rid of new client ID and SEC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668755367
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks" :errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'" :breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
`parentId` is the computed function, the title is just the ternary operation. I don't think it's better to add the title to the computed function it uses unnecessary cache memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] dinukadesilva commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
dinukadesilva commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668772496
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type, ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
Eg: -The custos portal source is currently being used as an npm dependency for EMC portal where this is currently needed.
https://github.com/SciGaP/emcenter-gateway/blob/master/package.json#L12
https://github.com/SciGaP/emcenter-gateway/blob/master/src/pages/storage/storage-preference-new.vue#L131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668776774
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks" :errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'" :breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
I understand that, but all the computed functions are stored in the cache. `title` is used at only one place unlike `parentId`, making `title` as a computed function will consume cache moreover it has 2 options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668778993
##########
File path: src/lib/components/overlay/table-overlay-body.vue
##########
@@ -0,0 +1,143 @@
+<template>
Review comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668228852
##########
File path: src/router.js
##########
@@ -182,6 +182,15 @@ export default new Router({
component: () =>
import(/*webpackChunkName:"account"*/ "./lib/components/pages/TenantNewEntity")
},
+ {
Review comment:
I changed the name of the router for unique identification and passing entity parameters without using URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668236307
##########
File path: .gitignore
##########
@@ -1,3 +1,6 @@
-.idea
node_modules
+yarn-error.log
Review comment:
Removed `yarn-lock.log` and `package-lock.json` from `.gitignore` file. I don't think we need to keep track of `yarn-error.log` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] dinukadesilva commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
dinukadesilva commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668172064
##########
File path: .gitignore
##########
@@ -1,3 +1,6 @@
-.idea
node_modules
+yarn-error.log
Review comment:
Get rid of these changes
##########
File path: src/router.js
##########
@@ -182,6 +182,15 @@ export default new Router({
component: () =>
import(/*webpackChunkName:"account"*/ "./lib/components/pages/TenantNewEntity")
},
+ {
Review comment:
Lets get rid of this route by getting the entityId as a query parameter to the above route "/tenants/:clientId/entities/new"...
##########
File path: .env
##########
@@ -1,3 +1,3 @@
-VUE_APP_CLIENT_ID="custos-su8y67qnckn5eejwusnz-10000641"
-VUE_APP_CLIENT_SEC="wGo5SGduOofjqFpl3UrR8ngrTafGHMOQDInz3bF0"
+VUE_APP_CLIENT_ID="custos-6nwoqodstpe5mvcq09lh-10000101"
Review comment:
Take off this code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#issuecomment-877843263
Front-end now supports showing entity n-level tree structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r669738293
##########
File path: src/lib/components/pages/TenantEntities.vue
##########
@@ -89,7 +63,12 @@ export default {
return this.$route.params.clientId;
},
entities() {
- return this.$store.getters["entity/getEntities"]({clientId: this.clientId, ownerId: this.currentUsername})
Review comment:
Yeah, Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668794235
##########
File path: src/lib/components/overlay/table-overlay-body.vue
##########
@@ -0,0 +1,143 @@
+<template>
Review comment:
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r669686701
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks" :errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'" :breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
I'm keeping the condition as part of HTML, I don't feel like adding it into the cache for the single call/use purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] dinukadesilva commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
dinukadesilva commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668774812
##########
File path: src/lib/components/overlay/table-overlay-body.vue
##########
@@ -0,0 +1,143 @@
+<template>
Review comment:
Move this to blocks Krishna. You could use the overlays inside that if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668236307
##########
File path: .gitignore
##########
@@ -1,3 +1,6 @@
-.idea
node_modules
+yarn-error.log
Review comment:
Removed `yarn-lock.log` and `package-lock.json` from `.gitignore` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#issuecomment-877492250
Issue Enabling entity parent mapping #104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668790484
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type, ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
The parameter for Dispatch is `Object` and inside the dispatch, we are creating another Object based on the parameter object more like `...` spread operation. If the passed object doesn't have `parentId` it will automatically assign to `undefined` thus our functionality in both cases won't cause errors/exceptions.
I have already tested this passing object to dispatch without `parentId`, which successfully created entities at the root level.
https://github.com/sannidhi09/airavata-custos-portal/blob/child-entity-integration/src/lib/store/modules/entity.store.js#L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] dinukadesilva commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
dinukadesilva commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668769077
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks" :errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'" :breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
I meant like this.
https://github.com/apache/airavata-custos-portal/blob/master/src/lib/components/pages/ListTenants.vue#L132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668755367
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks" :errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'" :breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
parentId is the computed function, the title is just the ternary operation. I don't think it's better to add the title to the computed function it uses unnecessary cache memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668790484
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type, ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
The parameter for Dispatch is `Object` and inside the dispatch, we are creating another Object based on the parameter object more like `...` spread operation. If the passed object doesn't have `parentId` it will automatically assign to `undefined` thus our functionality in both cases won't cause errors/exceptions.
https://github.com/sannidhi09/airavata-custos-portal/blob/child-entity-integration/src/lib/store/modules/entity.store.js#L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668794235
##########
File path: src/lib/components/overlay/table-overlay-body.vue
##########
@@ -0,0 +1,143 @@
+<template>
Review comment:
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668790484
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type, ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
The parameter for Dispatch is `Object` and inside the dispatch, we are creating another Object based on the parameter object more like `...` spread operation. If the passed object doesn't have `parentId` it will automatically assign to `undefined` thus our functionality in both cases won't effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] isururanawaka merged pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
isururanawaka merged pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668227442
##########
File path: .gitignore
##########
@@ -1,3 +1,6 @@
-.idea
node_modules
+yarn-error.log
Review comment:
Should I need to remove only `yarn-error.log` or
`yarn-lock.log`
`package-lock.json`
`yarn.lock`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668756763
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -98,6 +109,13 @@ export default {
console.log("this.$route.params : ", this.$route.params);
return this.$route.params.clientId;
},
+ parentId(){
+ console.log("this.$route.params: ", this.$route.params);
+ if(this.$route.params.entityId !== undefined){
Review comment:
Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668776774
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks" :errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'" :breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
I understand that, but all the computed functions are stored in the cache. `title` is used at only one place unlike `parentId`, making `title` as a computed function will consume cache moreover it has only 2 options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] dinukadesilva commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
dinukadesilva commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668717509
##########
File path: src/lib/components/overlay/table-overlay-body.vue
##########
@@ -0,0 +1,143 @@
+<template>
Review comment:
@sannidhi09 Overlay means to show a kind of cover while the data is loading. Just to show some blocks while the data is fetching. So, what are you trying to do here? I guess you should move this to blocks.
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -1,11 +1,22 @@
<template>
- <TenantHome title="New Entity" :breadcrumb-links="breadcrumbLinks" :errors="errors">
+ <TenantHome :title="this.parentId?'New Child Entity':'New Entity'" :breadcrumb-links="breadcrumbLinks" :errors="errors">
Review comment:
Move this `title` to a computed function. Also, based on that the breadcrumb texts also can be changed.
##########
File path: src/lib/components/pages/TenantNewEntity.vue
##########
@@ -98,6 +109,13 @@ export default {
console.log("this.$route.params : ", this.$route.params);
return this.$route.params.clientId;
},
+ parentId(){
+ console.log("this.$route.params: ", this.$route.params);
+ if(this.$route.params.entityId !== undefined){
Review comment:
Just returning the `this.$route.params.entityId` is probably sufficient here.
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type, ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
Reinclude this return statement. It's been currently used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r669685635
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type, ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
I will add a return statement for `createEntity` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airavata-custos-portal] sannidhi09 commented on a change in pull request #105: Developed front end support to create child entities.
Posted by GitBox <gi...@apache.org>.
sannidhi09 commented on a change in pull request #105:
URL: https://github.com/apache/airavata-custos-portal/pull/105#discussion_r668762777
##########
File path: src/lib/store/modules/entity.store.js
##########
@@ -55,9 +55,9 @@ const actions = {
ext: entity.ext
});
},
- async createEntity(obj, {clientId, entityId, name, description, type, ownerId, fullText, binaryData}) {
- return await custosService.entities.createEntity({
Review comment:
I checked the code base, we are only using the `createEntity` function only in the `TenentNewEntity` component. If we want to avoid the `parentId` param we could send undefined which will replicate the same functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: custos-unsubscribe@airavata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org