You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/12/20 23:31:22 UTC
[GitHub] npawar commented on a change in pull request #3622: Start and stop
ControllerPeriodicTasks based on leadership changes
npawar commented on a change in pull request #3622: Start and stop ControllerPeriodicTasks based on leadership changes
URL: https://github.com/apache/incubator-pinot/pull/3622#discussion_r243450428
##########
File path: pinot-core/src/main/java/com/linkedin/pinot/core/periodictask/PeriodicTaskScheduler.java
##########
@@ -70,11 +73,19 @@ public void start(List<PeriodicTask> periodicTasks) {
}
}
+ /**
+ * Shutdown executor service and stop the periodic tasks
+ */
Review comment:
@sunithabeeram yes that's a good point, added the synchronization between start and stop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org