You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/26 05:02:34 UTC
[GitHub] [kafka] ableegoldman opened a new pull request #11263: MINOR: remove unused Properties from GraphNode#writeToTopology
ableegoldman opened a new pull request #11263:
URL: https://github.com/apache/kafka/pull/11263
While going through the StreamsBuilder#build method to see if any of the steps actually modify internal state, I noticed this GraphNode method accepts a Properties input parameter but never uses it in any of its implementations. We can remove this parameter to clean things up, and make it clear that writing nodes to the topology doesn't involve the app properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11263: MINOR: remove unused Properties from GraphNode#writeToTopology
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11263:
URL: https://github.com/apache/kafka/pull/11263#issuecomment-906828133
Two unrelated flaky test failures in the original build (`ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir` and `TransactionsTest.testCommitTransactionTimeout`)
I added a second commit after that build but just reverted it, so the changes are identical to what passed the tests and was approved by @cadonna . So it should be ok to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11263: MINOR: remove unused Properties from GraphNode#writeToTopology
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11263:
URL: https://github.com/apache/kafka/pull/11263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org