You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by LosD <gi...@git.apache.org> on 2016/05/12 10:09:41 UTC
[GitHub] metamodel pull request: Do already-loaded check before retrieving ...
GitHub user LosD opened a pull request:
https://github.com/apache/metamodel/pull/100
Do already-loaded check before retrieving connection.
This avoids an issue with excessive retrieving/returning Connections introduced in METAMODEL-142
Fixes METAMODEL-252
Tested a table copy using DataCleaner on a SQL Server table of 8 varchar(max) columns with 500000 entries: Goes from 69 seconds to 33 seconds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/LosD/metamodel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit 3eda9aca42fda26b1319ca4e8ddfc9d166e78f8f
Author: Dennis Du Kr�ger <de...@humaninference.com>
Date: 2016-05-12T09:35:18Z
Do already-loaded check before retrieving connection.
Fixes METAMODEL-252
commit 3992b55c1064b2afebbf9a333b801d71dfee00a6
Author: Dennis Du Kr�ger <de...@humaninference.com>
Date: 2016-05-12T09:51:30Z
Missed loadRelations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Do already-loaded check before retrieving ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/100#issuecomment-218874359
+1 from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Do already-loaded check before retrieving ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---