[jira] Commented: (THRIFT-49) BufferedTransport#close should flush

["Mark Slee (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607401#action_12607401 ] 

Mark Slee commented on THRIFT-49:
---------------------------------

Yes, this should happen. The C++ version is effectively identical.

  void close() {
    flush();
    transport_->close();
  }



> BufferedTransport#close should flush
> ------------------------------------
>
>                 Key: THRIFT-49
>                 URL: https://issues.apache.org/jira/browse/THRIFT-49
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Kevin Clark
>
> Currently it's implemented as such:
> {code}
> def close
>   @transport.close
> end
> {code}
> Probably just needs to call flush before @transport.close. I'll try to get to it after my fastbinary merge, this is mostly as a TODO.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.