You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "yoavcloud (via GitHub)" <gi...@apache.org> on 2025/07/13 14:38:01 UTC
[PR] Snowflake: Improve accuracy of lookahead in implicit LIMIT alias [datafusion-sqlparser-rs]
yoavcloud opened a new pull request, #1941:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1941
Some needed adjustments to the lookahead logic when considering the `LIMIT` keyword as an implicit table alias.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Improve accuracy of lookahead in implicit LIMIT alias [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1941:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1941#issuecomment-3085085656
It is pretty epic that this code keeps rolling along
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Improve accuracy of lookahead in implicit LIMIT alias [datafusion-sqlparser-rs]
Posted by "yoavcloud (via GitHub)" <gi...@apache.org>.
yoavcloud commented on code in PR #1941:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1941#discussion_r2209218297
##########
src/dialect/snowflake.rs:
##########
@@ -365,6 +364,18 @@ impl Dialect for SnowflakeDialect {
false
}
+ // `LIMIT` can be considered an alias as long as it's not followed by a value. For example:
+ // `SELECT * FROM tbl LIMIT WHERE 1=1` - alias
+ // `SELECT * FROM tbl LIMIT 3` - not an alias
+ Keyword::LIMIT
+ if matches!(
+ parser.peek_token().token,
+ Token::Number(_, _) | Token::Placeholder(_)
Review Comment:
Thanks for the great feedback! The latest commit introduces a more accurate lookahead logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Improve accuracy of lookahead in implicit LIMIT alias [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio merged PR #1941:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Improve accuracy of lookahead in implicit LIMIT alias [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #1941:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1941#discussion_r2204189666
##########
src/dialect/snowflake.rs:
##########
@@ -365,6 +364,18 @@ impl Dialect for SnowflakeDialect {
false
}
+ // `LIMIT` can be considered an alias as long as it's not followed by a value. For example:
+ // `SELECT * FROM tbl LIMIT WHERE 1=1` - alias
+ // `SELECT * FROM tbl LIMIT 3` - not an alias
+ Keyword::LIMIT
+ if matches!(
+ parser.peek_token().token,
+ Token::Number(_, _) | Token::Placeholder(_)
Review Comment:
from their [docs they seem to mention](https://docs.snowflake.com/en/sql-reference/constructs/limit#parameters) that null and empty string, `$` values are possible, could we also detect for those here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org