You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2011/09/09 17:49:08 UTC

[jira] [Created] (DIRSERVER-1659) the apacheds.sh/bat files contains a hard coded revision. This is not good

the apacheds.sh/bat files contains a hard coded revision. This is not good
--------------------------------------------------------------------------

                 Key: DIRSERVER-1659
                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1659
             Project: Directory ApacheDS
          Issue Type: Bug
    Affects Versions: 2.0.0-M3
            Reporter: Emmanuel Lecharny
            Priority: Blocker
             Fix For: 2.0.0-M4


Currently, we have hard coded the revision in the two batch files (service/apacheds.sh/bat).

When we cut a release, we will likely forget to change those versions. They should be generated while we process the release, before we push the files to the tags directory.

I don't know if it's possible though... 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (DIRSERVER-1659) the apacheds.sh/bat files contains a hard coded revision. This is not good

Posted by "Kiran Ayyagari (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466503#comment-13466503 ] 

Kiran Ayyagari commented on DIRSERVER-1659:
-------------------------------------------

so I ask this, should we keep the version number in the artifact's name? If we can drop that(using <finalName> in pom) this will be easy to solve. 

                
> the apacheds.sh/bat files contains a hard coded revision. This is not good
> --------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1659
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1659
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M3
>            Reporter: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0-M7
>
>
> Currently, we have hard coded the revision in the two batch files (service/apacheds.sh/bat).
> When we cut a release, we will likely forget to change those versions. They should be generated while we process the release, before we push the files to the tags directory.
> I don't know if it's possible though... 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (DIRSERVER-1659) the apacheds.sh/bat files contains a hard coded revision. This is not good

Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107654#comment-13107654 ] 

Pierre-Arnaud Marcelot commented on DIRSERVER-1659:
---------------------------------------------------

I agree we should try to have them generated instead of managing them by hand before and after each version change.

We could move them to 'src/main/resources' and have them filtered with the correct version by Maven during the build.
However, we won't have them anymore at the root of the 'service' project and we'll need to look at the filtered version in the target directory (nothing too complicated though).

> the apacheds.sh/bat files contains a hard coded revision. This is not good
> --------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1659
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1659
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M3
>            Reporter: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0-M4
>
>
> Currently, we have hard coded the revision in the two batch files (service/apacheds.sh/bat).
> When we cut a release, we will likely forget to change those versions. They should be generated while we process the release, before we push the files to the tags directory.
> I don't know if it's possible though... 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (DIRSERVER-1659) the apacheds.sh/bat files contains a hard coded revision. This is not good

Posted by "Kiran Ayyagari (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466506#comment-13466506 ] 

Kiran Ayyagari commented on DIRSERVER-1659:
-------------------------------------------

yeah, but am looking for an option to not move the current location(if possible) of the .sh and .bat files.
                
> the apacheds.sh/bat files contains a hard coded revision. This is not good
> --------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1659
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1659
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M3
>            Reporter: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0-M7
>
>
> Currently, we have hard coded the revision in the two batch files (service/apacheds.sh/bat).
> When we cut a release, we will likely forget to change those versions. They should be generated while we process the release, before we push the files to the tags directory.
> I don't know if it's possible though... 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (DIRSERVER-1659) the apacheds.sh/bat files contains a hard coded revision. This is not good

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRSERVER-1659:
-----------------------------------------

    Fix Version/s: 2.0.0-M8
    
> the apacheds.sh/bat files contains a hard coded revision. This is not good
> --------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1659
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1659
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M3
>            Reporter: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0-M7, 2.0.0-M8
>
>
> Currently, we have hard coded the revision in the two batch files (service/apacheds.sh/bat).
> When we cut a release, we will likely forget to change those versions. They should be generated while we process the release, before we push the files to the tags directory.
> I don't know if it's possible though... 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (DIRSERVER-1659) the apacheds.sh/bat files contains a hard coded revision. This is not good

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRSERVER-1659.
------------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.0.0-M7)

Fixed in the shell script for linux. No idea how to fix it for windows...
                
> the apacheds.sh/bat files contains a hard coded revision. This is not good
> --------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1659
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1659
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M3
>            Reporter: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0-M8
>
>
> Currently, we have hard coded the revision in the two batch files (service/apacheds.sh/bat).
> When we cut a release, we will likely forget to change those versions. They should be generated while we process the release, before we push the files to the tags directory.
> I don't know if it's possible though... 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (DIRSERVER-1659) the apacheds.sh/bat files contains a hard coded revision. This is not good

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRSERVER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466505#comment-13466505 ] 

Emmanuel Lecharny commented on DIRSERVER-1659:
----------------------------------------------

Pierre-Arnaud suggestion is good.

See http://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html
                
> the apacheds.sh/bat files contains a hard coded revision. This is not good
> --------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1659
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1659
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M3
>            Reporter: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0-M7
>
>
> Currently, we have hard coded the revision in the two batch files (service/apacheds.sh/bat).
> When we cut a release, we will likely forget to change those versions. They should be generated while we process the release, before we push the files to the tags directory.
> I don't know if it's possible though... 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (DIRSERVER-1659) the apacheds.sh/bat files contains a hard coded revision. This is not good

Posted by "Pierre-Arnaud Marcelot (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRSERVER-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre-Arnaud Marcelot updated DIRSERVER-1659:
----------------------------------------------

    Fix Version/s:     (was: 2.0.0-M4)
                   2.0.0-M5
    
> the apacheds.sh/bat files contains a hard coded revision. This is not good
> --------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1659
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1659
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M3
>            Reporter: Emmanuel Lecharny
>            Priority: Blocker
>             Fix For: 2.0.0-M5
>
>
> Currently, we have hard coded the revision in the two batch files (service/apacheds.sh/bat).
> When we cut a release, we will likely forget to change those versions. They should be generated while we process the release, before we push the files to the tags directory.
> I don't know if it's possible though... 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira