[GitHub] [commons-io] garydgregory commented on a change in pull request #195: [IO-710] Utilize java.io.UncheckedIOException; rethrow SecurityException

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #195:
URL: https://github.com/apache/commons-io/pull/195#discussion_r566178127



##########
File path: src/main/java/org/apache/commons/io/FileUtils.java
##########
@@ -1232,12 +1233,16 @@ public static boolean deleteQuietly(final File file) {
             if (file.isDirectory()) {
                 cleanDirectory(file);
             }
+        } catch (final SecurityException sec) {

Review comment:
       I am -1 to this as it defeats the simple purpose off the method. 
   
   As an aside, and what makes it worse is that the change is not even documented in the Javadoc.
   
   I suppose the Javadoc could be improved to say that no `Exception`s are thrown as opposed to "exceptions".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org