You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by tmpfs <gi...@git.apache.org> on 2016/01/14 06:29:08 UTC
[GitHub] couchdb-nmo pull request: Housekeeping
GitHub user tmpfs opened a pull request:
https://github.com/apache/couchdb-nmo/pull/23
Housekeeping
Some minor changes:
* Add missing babel-register dev dependency (required for test execution)
* Prevent npm warning on license field
* Note the required node version in the readme
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tmpfs/couchdb-nmo master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-nmo/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 45f38876f29d29e9fa0fdde2a5f18e4c135eab0d
Author: muji <fr...@gmail.com>
Date: 2016-01-14T05:18:07Z
Add missing babel-register dev dep.
Required for the test runner.
commit 9aece2dc7edd4b8535fd739e8195912918d05716
Author: muji <fr...@gmail.com>
Date: 2016-01-14T05:21:06Z
Make license field SPDX compatible.
Prevents annoying npm warning.
commit 02ebc8dbb76370011ee260789ac0a4bac3720d4e
Author: muji <fr...@gmail.com>
Date: 2016-01-14T05:24:55Z
Note required version of node in readme.
commit 50b1c3cf2e7b1012377b642e54ca1864d915c210
Author: muji <fr...@gmail.com>
Date: 2016-01-14T05:26:21Z
Fix readme link syntax.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Housekeeping
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/23#issuecomment-171573769
you can close the pr now (we can't)
thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Housekeeping
Posted by tmpfs <gi...@git.apache.org>.
Github user tmpfs commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/23#issuecomment-171628776
Great, nice one for merging promptly :)
I've got 2.0alpha running up nice and quickly thanks to Docker, I must say such a much better experience than previously building from source which as you know was fraught with issues (spidermonkey dep etc.). Great job! Got the tests up and running, would be good to get a decision on the issue regarding whether to require node 4 as that has a big impact on how we move forward.
https://github.com/robertkowalski/nmo/issues/41
I can look into the stack traces referenced in:
https://github.com/robertkowalski/nmo/issues/45
After we get a decision on #41 if you like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Housekeeping
Posted by tmpfs <gi...@git.apache.org>.
Github user tmpfs closed the pull request at:
https://github.com/apache/couchdb-nmo/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Housekeeping
Posted by tmpfs <gi...@git.apache.org>.
Github user tmpfs commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/23#issuecomment-171536670
Oops, looks like Robert caught the dev dep issue in:
https://github.com/apache/couchdb-nmo/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Housekeeping
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/23#issuecomment-171588828
thanks @tmpfs for this. This is awesome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: Housekeeping
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/23#issuecomment-171573173
+1 thank you! :)
i'll close my PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---