[GitHub] [pinot] richardstartin commented on pull request #7802: avoid binary searches in distinct count

[GitBox <gi...@apache.org>]

richardstartin commented on pull request #7802:
URL: https://github.com/apache/pinot/pull/7802#issuecomment-976509437


   @Jackie-Jiang it depends. Constructing bitmaps from unordered values is inefficient, and in general there's no point in using  `RoaringBitmapWriter`, so if the dictionary ids have a very large range this won't help much, but if the cardinality is less than the 2^16 this particular configuration will work very well because all the adds will be buffered into a small bitset, regardless of order. It's not clear to me how helpful this will be with unordered data with very high range though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org