You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2021/05/10 10:01:15 UTC

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #176: [SSHD-1017] Add support for chacha20-poly1305@openssh.com

tomaswolf commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r629230095



##########
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##########
@@ -70,6 +70,7 @@
      */
     public static final List<BuiltinCiphers> DEFAULT_CIPHERS_PREFERENCE = Collections.unmodifiableList(
             Arrays.asList(
+                    // BuiltinCiphers.cc20p1305_openssh, // TODO: enable by default when BouncyCastle available

Review comment:
       Why this? The AES256 ciphers also may not be available, but are unconditionally in this list.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org