You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2023/01/05 14:32:17 UTC

[GitHub] [kyuubi] ulysses-you commented on a diff in pull request #4098: Follow Trino String to parse statement

ulysses-you commented on code in PR #4098:
URL: https://github.com/apache/kyuubi/pull/4098#discussion_r1062537457


##########
kyuubi-server/src/main/antlr4/org/apache/kyuubi/sql/KyuubiSqlBaseLexer.g4:
##########
@@ -128,10 +127,9 @@ IDENTIFIER
     : [A-Za-z_$0-9\u0080-\uFFFF]*?[A-Za-z_$\u0080-\uFFFF]+?[A-Za-z_$0-9\u0080-\uFFFF]*
     ;
 
+// Follow Trino STRING
 STRING
     : '\'' ( ~'\'' | '\'\'' )* '\''
-    | 'R\'' (~'\'')* '\''
-    | 'R"'(~'"')* '"'

Review Comment:
   Good point. Then we also can not modify it which may break server parser. Server parser should follow Spark. how about adding a `TRINO_STRING` so they are isolated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org