[GitHub] [hudi] hbgstc123 commented on a diff in pull request #8546: [MINOR] Add log in flink compact/cluster commit sink for troubleshoot…

["hbgstc123 (via GitHub)" <gi...@apache.org>]

hbgstc123 commented on code in PR #8546:
URL: https://github.com/apache/hudi/pull/8546#discussion_r1176619896


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringCommitSink.java:
##########
@@ -141,6 +141,15 @@ private void commitIfNecessary(String instant, List<ClusteringCommitEvent> event
     }
   }
 
+  private boolean containFailedEvent(List<ClusteringCommitEvent> events) {
+    return events.stream().anyMatch(event -> {
+      if (event.isFailed()) {
+        LOG.warn("Failed clustering event from task " + event.getTaskID() + ", will rollback instant " + event.getInstant());
+      }

Review Comment:
   yes, log failed taskid to help finding error that fail the event.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org