You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/10 00:46:33 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

dongjoon-hyun opened a new pull request #29701:
URL: https://github.com/apache/spark/pull/29701


   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689902511






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689975081


   **[Test build #128473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128473/testReport)** for PR 29701 at commit [`82fecaf`](https://github.com/apache/spark/commit/82fecaf3bc052c35347f6a2fcbed6a4588684ad6).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689905168


   cc @cloud-fan and @HeartSaVioR 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689975508


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128473/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689984279


   I'll monitor Jenkins status.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29701:
URL: https://github.com/apache/spark/pull/29701#discussion_r486004493



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
##########
@@ -170,18 +170,20 @@ class DataStreamReaderWriterSuite extends StreamTest with BeforeAndAfter {
 
     LastOptions.clear()
 
-    df.writeStream
+    val query = df.writeStream
       .format("org.apache.spark.sql.streaming.test")
-      .option("opt1", "1")
-      .options(Map("opt2" -> "2"))

Review comment:
       good catch!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689941497


   Thank you, @viirya . Merged to master/3.0/2.4.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689985664


   Ok, I think it is fine as GitHub Actions passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689927111


   Thank you, @HeartSaVioR .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689979351


   BTW, `GitHub Action` also passed, so I merged this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689910378


   Thank you, @cloud-fan !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29701:
URL: https://github.com/apache/spark/pull/29701#discussion_r486000587



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
##########
@@ -170,18 +170,20 @@ class DataStreamReaderWriterSuite extends StreamTest with BeforeAndAfter {
 
     LastOptions.clear()
 
-    df.writeStream
+    val query = df.writeStream
       .format("org.apache.spark.sql.streaming.test")
-      .option("opt1", "1")
-      .options(Map("opt2" -> "2"))

Review comment:
       Previously, the test case used the same options here and line 162~163. This hides this test coverage bug.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689995915


   Ya. It looks okay for now. `branch-2.4` Maven also passed like the following. The `branch-3.0` and `master` Jenkins jobs didn't trigger on this commit yet and those will be terminated during midnight reset (PST).
   - https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-2.4-test-maven-hadoop-2.7/988/consoleFull
   ```
   DataStreamReaderWriterSuite:
   - write cannot be called on streaming datasets
   - resolve default source
   - resolve full class
   - options
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689902002


   **[Test build #128473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128473/testReport)** for PR 29701 at commit [`82fecaf`](https://github.com/apache/spark/commit/82fecaf3bc052c35347f6a2fcbed6a4588684ad6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689902002


   **[Test build #128473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128473/testReport)** for PR 29701 at commit [`82fecaf`](https://github.com/apache/spark/commit/82fecaf3bc052c35347f6a2fcbed6a4588684ad6).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29701:
URL: https://github.com/apache/spark/pull/29701


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689975504






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689978839


   Ur, let me check again. I checked in IntelliJ and run `build/sbt` streaming tests locally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689984279


   I'll monitor Jenkins status. BTW, the current GitHub Action result is the following.
   ![Screen Shot 2020-09-09 at 10 05 58 PM](https://user-images.githubusercontent.com/9700541/92683799-b6b6f700-f2e8-11ea-93fc-1177869152f4.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689981755


   I verified again locally. It works.
   
   Given the error message from Jenkins, the map seems to be overwritten to the read options back again by the streaming query. If not, it should fail before reaching `checkpointLocation` because we verify `assert(LastOptions.parameters("opt1") == "5")` before.
   ```
   sbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: Map("opt3" -> "3", "opt2" -> "2", "opt1" -> "1") did not contain key "checkpointLocation"
   	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
   ```
   
   To sum up, this looks like a long-standing flakiness between `LastOptions.parameters` and the dummy provider `class DefaultSource extends StreamSourceProvider with StreamSinkProvider` 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689975504


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689977450


   @dongjoon-hyun The test seems not passed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29701: [SPARK-32836][SS][TESTS] Fix DataStreamReaderWriterSuite to check writer options correctly

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29701:
URL: https://github.com/apache/spark/pull/29701#issuecomment-689902511






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org