You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Igor Kryvenko <kr...@gmail.com> on 2018/03/19 18:57:28 UTC
Re: Review Request 66131: HIVE-18983: Add support for table properties
inheritance in Create table like
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66131/
-----------------------------------------------------------
(Updated Март 19, 2018, 6:57 п.п.)
Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and Prasanth_J.
Bugs: HIVE-18983
https://issues.apache.org/jira/browse/HIVE-18983
Repository: hive-git
Description
-------
Currently, Create table like support table properties.
But it doesn't inherit table properties from original table.
It uses just default table properties and doesn't inherit properties from original table.
It would be great if create table like will inherit origin table properties and will override them if they are specified in query .
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2342fff2ebe7914dae4fe644c6a2182edf0ff08a
ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out e74be6221d08b7b06d56e63db9e94d6df8e0c388
ql/src/test/results/clientpositive/create_like.q.out 7c26a597a59de8a4861518e4279cd995446e9991
ql/src/test/results/clientpositive/create_like2.q.out 601b929a2d557255cbf29aa9a5ca3752eda41920
ql/src/test/results/clientpositive/explain_ddl.q.out 6506e89035e1f1b2b4950175f888f463183cd34d
standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java 78ea01d9687fe043d63441430c46b30c25cd9756
Diff: https://reviews.apache.org/r/66131/diff/1/
Testing
-------
Thanks,
Igor Kryvenko
Re: Review Request 66131: HIVE-18983: Add support for table properties
inheritance in Create table like
Posted by Igor Kryvenko <kr...@gmail.com>.
> On Март 19, 2018, 10:03 п.п., Vineet Garg wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
> > Lines 12767 (patched)
> > <https://reviews.apache.org/r/66131/diff/1/?file=1979896#file1979896line12769>
> >
> > Shouldn't this be under if(hivestatsautogather==false) ? Otherwise this will always end up clearing the stats properties.
I think it shouldn't be. It makes no sense.Because in DDLTask#createTableLike we will set up new stats properties for this table and stats from original table will be overrided.
- Igor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66131/#review199480
-----------------------------------------------------------
On Март 19, 2018, 6:57 п.п., Igor Kryvenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66131/
> -----------------------------------------------------------
>
> (Updated Март 19, 2018, 6:57 п.п.)
>
>
> Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and Prasanth_J.
>
>
> Bugs: HIVE-18983
> https://issues.apache.org/jira/browse/HIVE-18983
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently, Create table like support table properties.
> But it doesn't inherit table properties from original table.
> It uses just default table properties and doesn't inherit properties from original table.
> It would be great if create table like will inherit origin table properties and will override them if they are specified in query .
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2342fff2ebe7914dae4fe644c6a2182edf0ff08a
> ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out e74be6221d08b7b06d56e63db9e94d6df8e0c388
> ql/src/test/results/clientpositive/create_like.q.out 7c26a597a59de8a4861518e4279cd995446e9991
> ql/src/test/results/clientpositive/create_like2.q.out 601b929a2d557255cbf29aa9a5ca3752eda41920
> ql/src/test/results/clientpositive/explain_ddl.q.out 6506e89035e1f1b2b4950175f888f463183cd34d
> standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java 78ea01d9687fe043d63441430c46b30c25cd9756
>
>
> Diff: https://reviews.apache.org/r/66131/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Igor Kryvenko
>
>
Re: Review Request 66131: HIVE-18983: Add support for table properties
inheritance in Create table like
Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66131/#review199480
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Lines 12767 (patched)
<https://reviews.apache.org/r/66131/#comment279787>
Shouldn't this be under if(hivestatsautogather==false) ? Otherwise this will always end up clearing the stats properties.
- Vineet Garg
On March 19, 2018, 6:57 p.m., Igor Kryvenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66131/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 6:57 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and Prasanth_J.
>
>
> Bugs: HIVE-18983
> https://issues.apache.org/jira/browse/HIVE-18983
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently, Create table like support table properties.
> But it doesn't inherit table properties from original table.
> It uses just default table properties and doesn't inherit properties from original table.
> It would be great if create table like will inherit origin table properties and will override them if they are specified in query .
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 2342fff2ebe7914dae4fe644c6a2182edf0ff08a
> ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out e74be6221d08b7b06d56e63db9e94d6df8e0c388
> ql/src/test/results/clientpositive/create_like.q.out 7c26a597a59de8a4861518e4279cd995446e9991
> ql/src/test/results/clientpositive/create_like2.q.out 601b929a2d557255cbf29aa9a5ca3752eda41920
> ql/src/test/results/clientpositive/explain_ddl.q.out 6506e89035e1f1b2b4950175f888f463183cd34d
> standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java 78ea01d9687fe043d63441430c46b30c25cd9756
>
>
> Diff: https://reviews.apache.org/r/66131/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Igor Kryvenko
>
>
Re: Review Request 66131: HIVE-18983: Add support for table properties
inheritance in Create table like
Posted by Igor Kryvenko <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66131/
-----------------------------------------------------------
(Updated Апрель 19, 2018, 12:53 п.п.)
Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and Prasanth_J.
Bugs: HIVE-18983
https://issues.apache.org/jira/browse/HIVE-18983
Repository: hive-git
Description
-------
Currently, Create table like support table properties.
But it doesn't inherit table properties from original table.
It uses just default table properties and doesn't inherit properties from original table.
It would be great if create table like will inherit origin table properties and will override them if they are specified in query .
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 88b5ed8
ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out e74be62
ql/src/test/results/clientpositive/create_like.q.out 7c26a59
ql/src/test/results/clientpositive/create_like2.q.out 601b929
ql/src/test/results/clientpositive/explain_ddl.q.out 6506e89
standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java 78ea01d
Diff: https://reviews.apache.org/r/66131/diff/4/
Changes: https://reviews.apache.org/r/66131/diff/3-4/
Testing
-------
Thanks,
Igor Kryvenko
Re: Review Request 66131: HIVE-18983: Add support for table properties
inheritance in Create table like
Posted by Igor Kryvenko <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66131/
-----------------------------------------------------------
(Updated Апрель 6, 2018, 5:34 п.п.)
Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and Prasanth_J.
Bugs: HIVE-18983
https://issues.apache.org/jira/browse/HIVE-18983
Repository: hive-git
Description
-------
Currently, Create table like support table properties.
But it doesn't inherit table properties from original table.
It uses just default table properties and doesn't inherit properties from original table.
It would be great if create table like will inherit origin table properties and will override them if they are specified in query .
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 99e2c72d212cfaefe463b1fa32239d6b63aa9228
ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out e74be6221d08b7b06d56e63db9e94d6df8e0c388
ql/src/test/results/clientpositive/create_like.q.out 7c26a597a59de8a4861518e4279cd995446e9991
ql/src/test/results/clientpositive/create_like2.q.out 601b929a2d557255cbf29aa9a5ca3752eda41920
ql/src/test/results/clientpositive/explain_ddl.q.out 6506e89035e1f1b2b4950175f888f463183cd34d
standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java 78ea01d9687fe043d63441430c46b30c25cd9756
Diff: https://reviews.apache.org/r/66131/diff/3/
Changes: https://reviews.apache.org/r/66131/diff/2-3/
Testing
-------
Thanks,
Igor Kryvenko
Re: Review Request 66131: HIVE-18983: Add support for table properties
inheritance in Create table like
Posted by Igor Kryvenko <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66131/
-----------------------------------------------------------
(Updated Апрель 1, 2018, 9:13 д.п.)
Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and Prasanth_J.
Bugs: HIVE-18983
https://issues.apache.org/jira/browse/HIVE-18983
Repository: hive-git
Description
-------
Currently, Create table like support table properties.
But it doesn't inherit table properties from original table.
It uses just default table properties and doesn't inherit properties from original table.
It would be great if create table like will inherit origin table properties and will override them if they are specified in query .
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 99e2c72d212cfaefe463b1fa32239d6b63aa9228
ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out e74be6221d08b7b06d56e63db9e94d6df8e0c388
ql/src/test/results/clientpositive/create_like.q.out 7c26a597a59de8a4861518e4279cd995446e9991
ql/src/test/results/clientpositive/create_like2.q.out 601b929a2d557255cbf29aa9a5ca3752eda41920
ql/src/test/results/clientpositive/explain_ddl.q.out 6506e89035e1f1b2b4950175f888f463183cd34d
standalone-metastore/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java 78ea01d9687fe043d63441430c46b30c25cd9756
Diff: https://reviews.apache.org/r/66131/diff/2/
Changes: https://reviews.apache.org/r/66131/diff/1-2/
Testing
-------
Thanks,
Igor Kryvenko