You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "VitalyKapustin-git (via GitHub)" <gi...@apache.org> on 2023/08/14 12:43:53 UTC
[GitHub] [superset] VitalyKapustin-git opened a new issue, #24978: Incorrect split dot for databases and schemas
VitalyKapustin-git opened a new issue, #24978:
URL: https://github.com/apache/superset/issues/24978
https://github.com/apache/superset/blob/571f33536e627ccf8b6cafac1d8c296e442e1ef6/superset/security/manager.py#L316-L317
I've named my database in database connections by FQDN like example.mycompany.local this code will work incorrect.
I'll get `[exampl` for database var and `ny` for schema var.
Could we prevent that if take last element from split array and replace slice to `replace()`?
`schema_name = schema_permission.split(".")[-1].replace('[', '').replace(']', '')`
`database_name = schema_permission.split(".")[0].replace('[', '').replace(']', '')`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Incorrect split dot for databases and schemas [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #24978:
URL: https://github.com/apache/superset/issues/24978#issuecomment-1979953724
@VitalyKapustin-git That does seem more forgiving! Would you be willing to open a PR with that change, and hopefully a unit test that passes with your previously failing case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org