You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/19 13:11:38 UTC

[GitHub] [dolphinscheduler] iamliangdi opened a new pull request, #10135: fix-10131: closed

iamliangdi opened a new pull request, #10135:
URL: https://github.com/apache/dolphinscheduler/pull/10135

   
   Missing parameters added.
   
   Is the merge request I submitted correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10135: fix-10131: closed

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10135:
URL: https://github.com/apache/dolphinscheduler/pull/10135#issuecomment-1132359559

   Hi @iamliangdi ,Could you descirbe why did you want to do that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] iamliangdi commented on pull request #10135: fix-10131: closed

Posted by GitBox <gi...@apache.org>.
iamliangdi commented on PR #10135:
URL: https://github.com/apache/dolphinscheduler/pull/10135#issuecomment-1132378547

   > To target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, jus desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.
   > 
   > BTW, your target branch should be `dev`. Please rebase your code to `dev` branch and change the target branch to `dev`
   
   Sorry, I was wrong


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] iamliangdi commented on pull request #10135: fix-10131: closed

Posted by GitBox <gi...@apache.org>.
iamliangdi commented on PR #10135:
URL: https://github.com/apache/dolphinscheduler/pull/10135#issuecomment-1132369954

   > 
   Please check the issues description about #10131 in version 3.0.0-alpha
   Missing parameter in mapper layer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10135: fix-10131: closed

Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10135:
URL: https://github.com/apache/dolphinscheduler/pull/10135#issuecomment-1132371867

   > Please check the issues description about #10131 in version 3.0.0-alpha Missing parameter in mapper layer
   
   To target specific issue from PR, we recommend use keyword fix: #issue_id or close: #issue_id or closes: #issue_id in your PR describe(not title, jus desc). It would not only connect issue to PR but also close issue automatically when PR is be closed.
   
   BTW, your target branch should be ```dev```. Please rebase your code to ```dev``` branch and change the target branch to ```dev```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] iamliangdi closed pull request #10135: fix-10131: closed

Posted by GitBox <gi...@apache.org>.
iamliangdi closed pull request #10135: fix-10131: closed
URL: https://github.com/apache/dolphinscheduler/pull/10135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org