You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2024/07/18 18:02:59 UTC
[PR] Datasets UI Improvements [airflow]
bbovenzi opened a new pull request, #40871:
URL: https://github.com/apache/airflow/pull/40871
In anticipation of Dataset Aliases, the Datasets page is getting a refresh. What really matters are events, so this update allows us to emphasize Dataset Events and sets us up to show more event details in the future.
Most notably,
- add a Dataset Events list to show all dataset events across all datasets
- the dataset events was changed from a table to a list of cards with more richly displayed information (source, downstream runs, extra)
- show dataset events, details, datasets list and the graph in separate tabs vs trying to squeeze everything into one view
- new breadcrumb to show if a dataset is selected (later on we will allow users to select dataset events)
- Richer dataset details (extra, consuming dags, producing tasks)
<img width="1100" alt="Screenshot 2024-07-18 at 1 53 41 PM" src="https://github.com/user-attachments/assets/a6faebdf-d53d-4811-bb0c-39b96c597075">
<img width="1098" alt="Screenshot 2024-07-18 at 1 52 59 PM" src="https://github.com/user-attachments/assets/cdb194b5-980c-4a87-96a4-589eacd2d268">
<img width="1098" alt="Screenshot 2024-07-18 at 1 53 09 PM" src="https://github.com/user-attachments/assets/78d7e7e8-2675-4eb9-9abc-ee8b0b2d03f9">
<img width="1097" alt="Screenshot 2024-07-18 at 2 02 18 PM" src="https://github.com/user-attachments/assets/b659eb94-b4c6-4923-9d6e-e222786fe0f4">
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Datasets UI Improvements [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #40871:
URL: https://github.com/apache/airflow/pull/40871#issuecomment-2246860249
@bbovenzi looked good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Datasets UI Improvements [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #40871:
URL: https://github.com/apache/airflow/pull/40871#issuecomment-2245912270
@vatsrahul1001
I added links to datasets, dagruns and task instances. Also, we're now using the same card component in the DAG details.
I switched the `extra` fields to render as json, it starts as collapsed but will scroll if it exceeds 300px
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Datasets UI Improvements [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #40871:
URL: https://github.com/apache/airflow/pull/40871#issuecomment-2242695379
@bbovenzi is it possible to provide DAG run id link in source and triggered
<img width="1713" alt="image" src="https://github.com/user-attachments/assets/10fbbce4-4064-4651-a5d7-c44c510bfb22">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Datasets UI Improvements [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #40871:
URL: https://github.com/apache/airflow/pull/40871#issuecomment-2245531485
> @bbovenzi can we have a scroll in the list of cards showing dataset events extra? Also spacing between source and extras increases as we increase num of extra
>
> Screen.Recording.2024-07-22.at.4.31.08.PM.mov
Ok I have a follow up branch for a event details page. Perhaps we should only show `extra` then. Otherwise each card can be wildly different heights
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Datasets UI Improvements [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #40871:
URL: https://github.com/apache/airflow/pull/40871#issuecomment-2242692250
@bbovenzi can we have a scroll in the list of cards showing dataset events extra? Also spacing between source and extras increases as we increase num of extra
https://github.com/user-attachments/assets/e569db88-1fe9-473b-85ad-0cc3eb0767b6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Datasets UI Improvements [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #40871:
URL: https://github.com/apache/airflow/pull/40871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org