You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/10/25 16:48:05 UTC
[GitHub] [drill] vdiravka opened a new pull request #2349: Introducing lgtm.yml file
vdiravka opened a new pull request #2349:
URL: https://github.com/apache/drill/pull/2349
- add licence header
# Introducing lgtm.yml file
## Description
Test PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka edited a comment on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka edited a comment on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-958981840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka commented on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-951744931
> This build failed with new random failures: https://github.com/apache/drill/runs/3999843934?check_suite_focus=true
>
> ```
> 2021-10-25T17:40:07.6137042Z [ERROR] Failures:
> 2021-10-25T17:40:07.6140322Z [ERROR] org.apache.drill.exec.server.TestDrillbitResilience.cancelInMiddleOfFetchingResults
> 2021-10-25T17:40:07.6144701Z [ERROR] Run 1: TestDrillbitResilience.cancelInMiddleOfFetchingResults:375 We are leaking 3000000 bytes ==> expected: <0> but was: <3000000>
> 2021-10-25T17:40:07.6146420Z [INFO] Run 2: PASS
> 2021-10-25T17:40:07.6147413Z [INFO] Run 3: PASS
> 2021-10-25T17:40:07.6148195Z [INFO]
> 2021-10-25T17:40:07.6152229Z [ERROR] TestDrillbitResilience.foreman_runTryEnd:289->testForeman:973->assertFailsWithException:960->assertFailsWithException:954 Query state should be FAILED (and not COMPLETED). ==> expected: <COMPLETED> but was: <FAILED>
> ```
>
> Is it possible that it is related to [304230a](https://github.com/apache/drill/commit/304230a289505526e1ff1bb1aae932517b7b6965)?
Looks like there is just not a right time for `CancellingThread` and `countAllocatedMemory`. Checkinng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka closed pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka closed pull request #2349:
URL: https://github.com/apache/drill/pull/2349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka commented on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-951215645
You are right, we have `drill-patch-review.py` file. I am checking it whether we still need it. Looks like it was introduced in 2013 for reviewboard, so currently is not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre commented on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-951194378
@vdiravka I think the reason those other checks are there is that Drill actually does ship with a few random python scripts and the d3 stuff relating to the web UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka edited a comment on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka edited a comment on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-958981840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka edited a comment on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka edited a comment on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-958981840
Looks like the LGTM build can't be eliminated from PR checks in non enterprise version, so close [INFRA-22447](https://issues.apache.org/jira/browse/INFRA-22447).
But it possibly can be disabled with #2362 and [DRILL-8032](https://issues.apache.org/jira/browse/DRILL-8032)
For CI test failures 2361 is opened [DRILL-8030](https://issues.apache.org/jira/browse/DRILL-8030).
And lgtm.yml file is already introduced in 2358. So close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka closed pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka closed pull request #2349:
URL: https://github.com/apache/drill/pull/2349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka edited a comment on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka edited a comment on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-958981840
Looks like the LGTM build can't be eliminated from PR checks in non enterprise version, so close [INFRA-22447](https://issues.apache.org/jira/browse/INFRA-22447).
But it possibly can be disabled with #2362 and [DRILL-8032](https://issues.apache.org/jira/browse/DRILL-8032)
For CI test failures 2361 is opened [DRILL-8030](https://issues.apache.org/jira/browse/DRILL-8030).
And lgtm.yml file is already introduced in 2358. So close this draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka edited a comment on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka edited a comment on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-958981840
Looks like the LGTM build can't be eliminated from PR checks in non enterprise version, so close [INFRA-22447](https://issues.apache.org/jira/browse/INFRA-22447).
But it possibly can be disabled with #2362 and [DRILL-8032](https://issues.apache.org/jira/browse/DRILL-8032)
For CI test failures 2361 is opened [DRILL-8030](https://issues.apache.org/jira/browse/DRILL-8030).
And lgtm.yml file is already introduced in 2358. So close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-951257233
This build failed with new random failures:
https://github.com/apache/drill/runs/3999843934?check_suite_focus=true
```
2021-10-25T17:40:07.6137042Z [ERROR] Failures:
2021-10-25T17:40:07.6140322Z [ERROR] org.apache.drill.exec.server.TestDrillbitResilience.cancelInMiddleOfFetchingResults
2021-10-25T17:40:07.6144701Z [ERROR] Run 1: TestDrillbitResilience.cancelInMiddleOfFetchingResults:375 We are leaking 3000000 bytes ==> expected: <0> but was: <3000000>
2021-10-25T17:40:07.6146420Z [INFO] Run 2: PASS
2021-10-25T17:40:07.6147413Z [INFO] Run 3: PASS
2021-10-25T17:40:07.6148195Z [INFO]
2021-10-25T17:40:07.6152229Z [ERROR] TestDrillbitResilience.foreman_runTryEnd:289->testForeman:973->assertFailsWithException:960->assertFailsWithException:954 Query state should be FAILED (and not COMPLETED). ==> expected: <COMPLETED> but was: <FAILED>
```
Is it possible that it is related to https://github.com/apache/drill/commit/304230a289505526e1ff1bb1aae932517b7b6965?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka closed pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka closed pull request #2349:
URL: https://github.com/apache/drill/pull/2349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka commented on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-958981840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka commented on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-951143155
Looks like build can't be eliminated from the list by configuring lgtm.yml file:
https://help.semmle.com/lgtm-enterprise/admin/help/disabling-analysis-language.html
So https://issues.apache.org/jira/browse/INFRA-22447 created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka commented on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-958981840
Looks like the LGTM build can't be eliminated from PR checks in non enterprise version, so close [INFRA-22447](https://issues.apache.org/jira/browse/INFRA-22447).
But it possibly can be disabled with 2362 and [DRILL-8032](https://issues.apache.org/jira/browse/DRILL-8032)
For CI test failures 2361 is opened [DRILL-8030](https://issues.apache.org/jira/browse/DRILL-8030).
And lgtm.yml file is already introduced in 2358. So close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on pull request #2349: Introducing lgtm.yml file
Posted by GitBox <gi...@apache.org>.
vdiravka commented on pull request #2349:
URL: https://github.com/apache/drill/pull/2349#issuecomment-958981840
Looks like the LGTM build can't be eliminated from PR checks in non enterprise version, so close [INFRA-22447](https://issues.apache.org/jira/browse/INFRA-22447).
But it possibly can be disabled with 2362 and [DRILL-8032](https://issues.apache.org/jira/browse/DRILL-8032)
For CI test failures 2361 is opened [DRILL-8030](https://issues.apache.org/jira/browse/DRILL-8030).
And lgtm.yml file is already introduced in 2358. So close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org