You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/12 00:15:47 UTC

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2284: stm32h7/stm32_dmamux.h: Fix errors in bitfield definitions

hartmannathan opened a new pull request #2284:
URL: https://github.com/apache/incubator-nuttx/pull/2284


   ## Summary
   
   arch/arm/src/stm32h7/hardware/stm32_dmamux.h:
   
       * DMAMUX1_CSR_SOF(x): Add parenthesis around macro parameter
         expansion.
   
       * DMAMUX1_CFR_SOF(x): Rename to DMAMUX1_CFR_CSOF(x) for
         consistency with datasheet and add parenthesis around macro
         parameter expansion.
   
       * DMAMUX_RGCR_GPOL_MASK: Fix incorrect mask. Was 7 (3 bits) but
         datasheet shows only 2 bits.
   
       * Add missing defines DMAMUX_RGCR_GPOL_NONE,
         DMAMUX_RGCR_GPOL_RISING, DMAMUX_RGCR_GPOL_FALLING, and
         DMAMUX_RGCR_GPOL_BOTH.
   
       * DMAMUX_RGCR_GNBREQ_SHIFT: Fix incorrect value. Was 17 (collision
         with DMAMUX_RGCR_GPOL_SHIFT) but datasheet and comment both show
         this bitfield at bits 19-23.
   
       * DMAMUX_RGCR_GNBREQL_MASK: Fix incorrect mask. Was 7 (3 bits) but
         datasheet shows 5 bits.
   
       * DMAMUX1_RGSR_SOF(x): Rename to DMAMUX1_RGSR_OF(x) for
         consistency with datasheet and add parenthesis around macro
         parameter expansion.
   
       * DMAMUX1_RGCFR_SOF(x): Rename to DMAMUX1_RGCFR_COF(x) for
         consistency with datasheet and add parenthesis around macro
         parameter expansion.
   
       * DMAMAP_MAP(d,c): Add parenthesis around macro parameter
         expansion.
   
   ## Impact
   
   Corrects bitfield mistakes.
   
   ## Testing
   
   nxstyle


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] raiden00pl merged pull request #2284: stm32h7/stm32_dmamux.h: Fix errors in bitfield definitions

Posted by GitBox <gi...@apache.org>.
raiden00pl merged pull request #2284:
URL: https://github.com/apache/incubator-nuttx/pull/2284


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #2284: stm32h7/stm32_dmamux.h: Fix errors in bitfield definitions

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #2284:
URL: https://github.com/apache/incubator-nuttx/pull/2284#issuecomment-726018785


   @hartmannathan - good catch!
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org