You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/06 04:05:58 UTC

[GitHub] [incubator-kyuubi] zwangsheng commented on a change in pull request #1495: [KYUUBI #1480] Fix bug in docker-image-tool & Provider image way to config SPARK instead of local copy

zwangsheng commented on a change in pull request #1495:
URL: https://github.com/apache/incubator-kyuubi/pull/1495#discussion_r762689323



##########
File path: bin/docker-image-tool.sh
##########
@@ -118,11 +120,17 @@ function build {
   # else use builtin spark
   if [[ ! -d "$KYUUBI_ROOT/spark-binary" ]]; then
     mkdir "$KYUUBI_ROOT/spark-binary"
+  else
+    rm -rf "$KYUUBI_ROOT/spark-binary/*"

Review comment:
       The logic is if this dir exists, it is considered that the spark was used last time.  The spark version that was used last time is saved. Delete spark first and do copy or nothing according to `-w` parameters.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org