You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Andreas Hubold (JIRA)" <ji...@apache.org> on 2019/01/03 09:16:00 UTC

[jira] [Commented] (MSHARED-792) Maven Dependency Analyzer ignores Java 8 type annotations on local variables

    [ https://issues.apache.org/jira/browse/MSHARED-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732790#comment-16732790 ] 

Andreas Hubold commented on MSHARED-792:
----------------------------------------

This ticket is about "type annotations". Annotations on local variables that aren't type annotations are also not detected but this would be a different ticket and my proposed fix does not fix this. You could test this by meta-annotating the Example annotation from  [^example.tgz]  with {{@Target(ElementType.LOCAL_VARIABLE)}}. I haven't found the place where ASM would report those - org.objectweb.asm.MethodVisitor#visitLocalVariableAnnotation seems to be called for type annotations only.

> Maven Dependency Analyzer ignores Java 8 type annotations on local variables
> ----------------------------------------------------------------------------
>
>                 Key: MSHARED-792
>                 URL: https://issues.apache.org/jira/browse/MSHARED-792
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-dependency-analyzer
>    Affects Versions: maven-dependency-analyzer-1.11.1
>            Reporter: Andreas Hubold
>            Priority: Major
>         Attachments: example.tgz
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Maven Dependency Analyzer's DefaultMethodVisitor does not overwrite org.objectweb.asm.MethodVisitor#visitLocalVariableAnnotation. Because of this, type annotations on local variables are not detected.
> Attached example Maven project to reproduce the bug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)