You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/14 08:03:43 UTC

[GitHub] [flink] liuyongvs opened a new pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

liuyongvs opened a new pull request #12144:
URL: https://github.com/apache/flink/pull/12144


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   - this PR supports  read hbase conf dir from flink.conf just like hadoop_conf does
   
   
   ## Brief change log
   
   
   ## Verifying this change
   - i have verified in our production
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes )
     - If yes, how is the feature documented? (**docs**)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] carp84 edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
carp84 edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-635496437


   @liuyongvs I meant adding a test case for loading hbase conf (e.g. `HBaseConfigLoadingTest`) just like what we do now in `HadoopConfigLoadingTest#loadFromEnvVariables`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 3df97a6fdb130416fa447295f4ac7eb174be9cc4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557) 
   * 84f420d9043272150872fe4a32c2eaad2400a750 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on a change in pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on a change in pull request #12144:
URL: https://github.com/apache/flink/pull/12144#discussion_r434939475



##########
File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/util/HBaseConfigLoadingTest.java
##########
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.hbase.util;
+
+import org.apache.flink.core.testutils.CommonTestUtils;
+
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Tests that validate the loading of the HBase configuration, relative to
+ * entries in the Flink configuration and the environment variables.
+ */
+@SuppressWarnings("deprecation")

Review comment:
       have removed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 497b8ff078b4055c3a69b56e762dfecb7973c3a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501) 
   * a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-636780344


   hi @carp84 @rmetzger , my test all have passed. and the error is not relevent with my code. Do i also need push a empty commits to make the CI succeed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5addfcff9eb59b5153e76627ed74e7255fe8b69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292) 
   * 5ab91c03e9eb771441a920876047849406f43261 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-635782175


   hi @carp84 , i add a HBaseUtils to get hbase conf and unit test for that


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-630127290


   To trigger a new build, you need to push a change (rebase, or empty commit)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] carp84 commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-635496437


   @liuyongvs I meant adding a test case for loading hbase conf (e.g. `HBaseConfigLoadingTest`) just like what we does now in `HadoopConfigLoadingTest#loadFromEnvVariables`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] carp84 commented on a change in pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #12144:
URL: https://github.com/apache/flink/pull/12144#discussion_r434560352



##########
File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/util/HBaseConfigLoadingTest.java
##########
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.hbase.util;
+
+import org.apache.flink.core.testutils.CommonTestUtils;
+
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Tests that validate the loading of the HBase configuration, relative to
+ * entries in the Flink configuration and the environment variables.
+ */
+@SuppressWarnings("deprecation")

Review comment:
       There's no warning to suppress actually, we could remove this annotation.

##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/util/HBaseConfigurationUtil.java
##########
@@ -22,20 +22,85 @@
 import org.apache.flink.util.Preconditions;
 
 import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseConfiguration;
 import org.apache.hadoop.io.Writable;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.DataInputStream;
 import java.io.DataOutputStream;
+import java.io.File;
 import java.io.IOException;
 
 /**
- * This class helps to do serialization for hadoop Configuration.
+ * This class helps to do serialization for hadoop Configuration and HBase-related classes.
  */
 @Internal
 public class HBaseConfigurationUtil {
 
+	private static final Logger LOG = LoggerFactory.getLogger(HBaseConfigurationUtil.class);
+
+	@SuppressWarnings("deprecation")

Review comment:
       There's no deprecated warning for this method thus no suppress needed. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 39473b65812e37f869293f144227601eb70ff3e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425) 
   * 35f180a59746b17b3b965254b8bcdcb21e75a3c5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 8e7b3c64b9f15cd71c844efda5b2f31c4a163e20 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on a change in pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on a change in pull request #12144:
URL: https://github.com/apache/flink/pull/12144#discussion_r434940045



##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/util/HBaseConfigurationUtil.java
##########
@@ -22,20 +22,85 @@
 import org.apache.flink.util.Preconditions;
 
 import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseConfiguration;
 import org.apache.hadoop.io.Writable;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.DataInputStream;
 import java.io.DataOutputStream;
+import java.io.File;
 import java.io.IOException;
 
 /**
- * This class helps to do serialization for hadoop Configuration.
+ * This class helps to do serialization for hadoop Configuration and HBase-related classes.
  */
 @Internal
 public class HBaseConfigurationUtil {
 
+	private static final Logger LOG = LoggerFactory.getLogger(HBaseConfigurationUtil.class);
+
+	@SuppressWarnings("deprecation")
+	public static Configuration getHBaseConfiguration() {
+
+		// Instantiate an HBaseConfiguration to load the hbase-default.xml and hbase-site.xml from the classpath.
+		Configuration result = new HBaseConfiguration().create();

Review comment:
       yep, new HBaseConfiguration() is marked deprecation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-629091637


   > ## CI report:
   > * [5addfcf](https://github.com/apache/flink/commit/5addfcff9eb59b5153e76627ed74e7255fe8b69b) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292)
   > 
   > Bot commands
   > The @flinkbot bot supports the following commands:
   > * `@flinkbot run travis` re-run the last Travis build
   > * `@flinkbot run azure` re-run the last Azure build
   
   @flinkbot  run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2668",
       "triggerID" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "triggerType" : "PUSH"
     }, {
       "hash" : "30ac550d12c2eca22eaa4dab8f9186d7296355cd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2703",
       "triggerID" : "30ac550d12c2eca22eaa4dab8f9186d7296355cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 33b1ef0748285bc503363458a684ab237a64cd62 UNKNOWN
   * e701eb7677b535e07e4d5642ae9280cab084b854 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2668) 
   * 30ac550d12c2eca22eaa4dab8f9186d7296355cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2703) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs removed a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs removed a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628969254


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628468264


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d94801c55893bfc984f0d59ea53c70d30168465f (Thu May 14 08:07:02 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] carp84 commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-637059489


   @liuyongvs Thanks for updating the PR. Let me review first and see whether any change requested.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5addfcff9eb59b5153e76627ed74e7255fe8b69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292) 
   * 5ab91c03e9eb771441a920876047849406f43261 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2668",
       "triggerID" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "triggerType" : "PUSH"
     }, {
       "hash" : "30ac550d12c2eca22eaa4dab8f9186d7296355cd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "30ac550d12c2eca22eaa4dab8f9186d7296355cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 33b1ef0748285bc503363458a684ab237a64cd62 UNKNOWN
   * e701eb7677b535e07e4d5642ae9280cab084b854 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2668) 
   * 30ac550d12c2eca22eaa4dab8f9186d7296355cd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d94801c55893bfc984f0d59ea53c70d30168465f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264) 
   * 5addfcff9eb59b5153e76627ed74e7255fe8b69b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d94801c55893bfc984f0d59ea53c70d30168465f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-638543974


   hi @carp84 , i have already solved all your reviews


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-635706715


   @carp84 , but flink doesn't have a HadoopUtils


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 8e7b3c64b9f15cd71c844efda5b2f31c4a163e20 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521) 
   * 3df97a6fdb130416fa447295f4ac7eb174be9cc4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d94801c55893bfc984f0d59ea53c70d30168465f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs removed a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs removed a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-629091637


   > ## CI report:
   > * [5addfcf](https://github.com/apache/flink/commit/5addfcff9eb59b5153e76627ed74e7255fe8b69b) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292)
   > 
   > Bot commands
   > The @flinkbot bot supports the following commands:
   > * `@flinkbot run travis` re-run the last Travis build
   > * `@flinkbot run azure` re-run the last Azure build
   
   @flinkbot  run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] carp84 commented on a change in pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #12144:
URL: https://github.com/apache/flink/pull/12144#discussion_r435046468



##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/util/HBaseConfigurationUtil.java
##########
@@ -22,20 +22,85 @@
 import org.apache.flink.util.Preconditions;
 
 import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseConfiguration;
 import org.apache.hadoop.io.Writable;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.DataInputStream;
 import java.io.DataOutputStream;
+import java.io.File;
 import java.io.IOException;
 
 /**
- * This class helps to do serialization for hadoop Configuration.
+ * This class helps to do serialization for hadoop Configuration and HBase-related classes.
  */
 @Internal
 public class HBaseConfigurationUtil {
 
+	private static final Logger LOG = LoggerFactory.getLogger(HBaseConfigurationUtil.class);
+
+	@SuppressWarnings("deprecation")
+	public static Configuration getHBaseConfiguration() {
+
+		// Instantiate an HBaseConfiguration to load the hbase-default.xml and hbase-site.xml from the classpath.
+		Configuration result = new HBaseConfiguration().create();

Review comment:
       It seems this line is not updated in the new commit, maybe you missed the change? @liuyongvs  Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 497b8ff078b4055c3a69b56e762dfecb7973c3a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501) 
   * a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs removed a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs removed a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-635782175


   hi @carp84 , i add a HBaseUtils to get hbase conf and unit test for that


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 39473b65812e37f869293f144227601eb70ff3e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628969254


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5addfcff9eb59b5153e76627ed74e7255fe8b69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510) 
   * 8e7b3c64b9f15cd71c844efda5b2f31c4a163e20 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d94801c55893bfc984f0d59ea53c70d30168465f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 84f420d9043272150872fe4a32c2eaad2400a750 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592) 
   * 33b1ef0748285bc503363458a684ab237a64cd62 UNKNOWN
   * e701eb7677b535e07e4d5642ae9280cab084b854 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510) 
   * 8e7b3c64b9f15cd71c844efda5b2f31c4a163e20 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d94801c55893bfc984f0d59ea53c70d30168465f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264) 
   * 5addfcff9eb59b5153e76627ed74e7255fe8b69b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 84f420d9043272150872fe4a32c2eaad2400a750 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592) 
   * 33b1ef0748285bc503363458a684ab237a64cd62 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] carp84 commented on a change in pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
carp84 commented on a change in pull request #12144:
URL: https://github.com/apache/flink/pull/12144#discussion_r434597698



##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/util/HBaseConfigurationUtil.java
##########
@@ -22,20 +22,85 @@
 import org.apache.flink.util.Preconditions;
 
 import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseConfiguration;
 import org.apache.hadoop.io.Writable;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.DataInputStream;
 import java.io.DataOutputStream;
+import java.io.File;
 import java.io.IOException;
 
 /**
- * This class helps to do serialization for hadoop Configuration.
+ * This class helps to do serialization for hadoop Configuration and HBase-related classes.
  */
 @Internal
 public class HBaseConfigurationUtil {
 
+	private static final Logger LOG = LoggerFactory.getLogger(HBaseConfigurationUtil.class);
+
+	@SuppressWarnings("deprecation")
+	public static Configuration getHBaseConfiguration() {
+
+		// Instantiate an HBaseConfiguration to load the hbase-default.xml and hbase-site.xml from the classpath.
+		Configuration result = new HBaseConfiguration().create();

Review comment:
       ```suggestion
   		Configuration result = HBaseConfiguration.create();
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 84f420d9043272150872fe4a32c2eaad2400a750 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 3df97a6fdb130416fa447295f4ac7eb174be9cc4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2668",
       "triggerID" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 84f420d9043272150872fe4a32c2eaad2400a750 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592) 
   * 33b1ef0748285bc503363458a684ab237a64cd62 UNKNOWN
   * e701eb7677b535e07e4d5642ae9280cab084b854 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2668) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-630057647


   hi @rmetzger 
   I have committed my code, but the log is below, which is not relevant with my code
   
   2020-05-14T13:46:32.9352627Z
   [ERROR]
   Failures: 
   2020-05-14T13:46:32.9361371Z
   [ERROR]
   KafkaProducerExactlyOnceITCase>KafkaProducerTestBase.testExactlyOnceRegularSink:309->KafkaProducerTestBase.testExactlyOnce:370 Test failed: Job execution failed
   
   ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (end-to-end-tests) on project flink-metrics-availability-test: Unable to generate classpath: org.apache.maven.artifact.resolver.ArtifactResolutionException: Could not transfer artifact org.apache.maven.surefire:surefire-grouper:jar:2.22.1 from/to alicloud-mvn-mirror (http://mavenmirror.alicloud.dak8s.net:8888/repository/maven-central/): Entry
   [id:18]
   [route:{}->http://mavenmirror.alicloud.dak8s.net:8888]
   [state:null] has not been leased from this pool.
   
    
   How to solve it , and why that happends. how to make the flinkbot rerun azure.
    I am looking forward your response. Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 35f180a59746b17b3b965254b8bcdcb21e75a3c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454) 
   * 497b8ff078b4055c3a69b56e762dfecb7973c3a6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] rmetzger commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-630126819


   Hey,
   sorry for these issues.
   The Kafka issue is a known problem, also the maven artifact download. You don't have to do anything to resolve them.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-630113024


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs removed a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs removed a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628549495


   hi @rmetzger , why you cancelled my job


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2668",
       "triggerID" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "triggerType" : "PUSH"
     }, {
       "hash" : "30ac550d12c2eca22eaa4dab8f9186d7296355cd",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2703",
       "triggerID" : "30ac550d12c2eca22eaa4dab8f9186d7296355cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 33b1ef0748285bc503363458a684ab237a64cd62 UNKNOWN
   * 30ac550d12c2eca22eaa4dab8f9186d7296355cd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2703) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on a change in pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on a change in pull request #12144:
URL: https://github.com/apache/flink/pull/12144#discussion_r435096361



##########
File path: flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/util/HBaseConfigurationUtil.java
##########
@@ -22,20 +22,85 @@
 import org.apache.flink.util.Preconditions;
 
 import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseConfiguration;
 import org.apache.hadoop.io.Writable;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.DataInputStream;
 import java.io.DataOutputStream;
+import java.io.File;
 import java.io.IOException;
 
 /**
- * This class helps to do serialization for hadoop Configuration.
+ * This class helps to do serialization for hadoop Configuration and HBase-related classes.
  */
 @Internal
 public class HBaseConfigurationUtil {
 
+	private static final Logger LOG = LoggerFactory.getLogger(HBaseConfigurationUtil.class);
+
+	@SuppressWarnings("deprecation")
+	public static Configuration getHBaseConfiguration() {
+
+		// Instantiate an HBaseConfiguration to load the hbase-default.xml and hbase-site.xml from the classpath.
+		Configuration result = new HBaseConfiguration().create();

Review comment:
       ok,  I mistook that it would add automatically when triggering the  button "Commit changes".
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 35f180a59746b17b3b965254b8bcdcb21e75a3c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628549495


   hi @rmetzger , why you cancelled my job


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5ab91c03e9eb771441a920876047849406f43261 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347) 
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-636780344


   hi @carp84 , my test all have passed. and the error is not relevent with my code. Do i also need push a empty commits to make the CI succeed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 39473b65812e37f869293f144227601eb70ff3e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425) 
   * 35f180a59746b17b3b965254b8bcdcb21e75a3c5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 497b8ff078b4055c3a69b56e762dfecb7973c3a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] carp84 closed pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
carp84 closed pull request #12144:
URL: https://github.com/apache/flink/pull/12144


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 3df97a6fdb130416fa447295f4ac7eb174be9cc4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557) 
   * 84f420d9043272150872fe4a32c2eaad2400a750 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5ab91c03e9eb771441a920876047849406f43261 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347) 
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 39473b65812e37f869293f144227601eb70ff3e7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 35f180a59746b17b3b965254b8bcdcb21e75a3c5 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454) 
   * 497b8ff078b4055c3a69b56e762dfecb7973c3a6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf and change HBaseConfiguration construction.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-628475376


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1264",
       "triggerID" : "d94801c55893bfc984f0d59ea53c70d30168465f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1292",
       "triggerID" : "5addfcff9eb59b5153e76627ed74e7255fe8b69b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5ab91c03e9eb771441a920876047849406f43261",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2347",
       "triggerID" : "5ab91c03e9eb771441a920876047849406f43261",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d36b959fb16a91c15babda10dd884cbbdec58420",
       "triggerType" : "PUSH"
     }, {
       "hash" : "39473b65812e37f869293f144227601eb70ff3e7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2425",
       "triggerID" : "39473b65812e37f869293f144227601eb70ff3e7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2454",
       "triggerID" : "35f180a59746b17b3b965254b8bcdcb21e75a3c5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2501",
       "triggerID" : "497b8ff078b4055c3a69b56e762dfecb7973c3a6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2510",
       "triggerID" : "a0fd8094daa24b484fbfdf2f2a0ec6d2b79271e6",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2521",
       "triggerID" : "8e7b3c64b9f15cd71c844efda5b2f31c4a163e20",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2557",
       "triggerID" : "3df97a6fdb130416fa447295f4ac7eb174be9cc4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2592",
       "triggerID" : "84f420d9043272150872fe4a32c2eaad2400a750",
       "triggerType" : "PUSH"
     }, {
       "hash" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "33b1ef0748285bc503363458a684ab237a64cd62",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2668",
       "triggerID" : "e701eb7677b535e07e4d5642ae9280cab084b854",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d36b959fb16a91c15babda10dd884cbbdec58420 UNKNOWN
   * 33b1ef0748285bc503363458a684ab237a64cd62 UNKNOWN
   * e701eb7677b535e07e4d5642ae9280cab084b854 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2668) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] liuyongvs commented on pull request #12144: [FLINK-17384][flink-dist] support read hbase conf dir from flink.conf.

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12144:
URL: https://github.com/apache/flink/pull/12144#issuecomment-635184211


   > Thanks for the contribution @liuyongvs ! Could you add a unit test referring to [HadoopConfigLoadingTest#loadFromEnvVariables](https://github.com/apache/flink/blob/1cd696d92c3e088a5bd8e5e11b54aacf46e92ae8/flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopConfigLoadingTest.java#L119) as a safeguard? Thanks.
   
   hi @carp84 , i think it may not add unit test in HadoopConfigLoadingTest#loadFromEnvVariables 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org