You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/09 11:25:28 UTC
Review Request 56488: Hive2: xxx; never returns
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-19938
https://issues.apache.org/jira/browse/AMBARI-19938
Repository: ambari
Description
-------
Added a modal for error.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js dcf27b4
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8ee8e87
Diff: https://reviews.apache.org/r/56488/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56488: Hive2: xxx; never returns
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/#review165390
-----------------------------------------------------------
contrib/views/hive20/src/main/resources/ui/app/adapters/query.js (line 32)
<https://reviews.apache.org/r/56488/#comment237224>
Not using dateSubmitted anymore. Why keep it?
contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js (line 19)
<https://reviews.apache.org/r/56488/#comment237223>
What is the use of this controller?
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 130)
<https://reviews.apache.org/r/56488/#comment237225>
Why not set model as an empty worksheet?
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 233)
<https://reviews.apache.org/r/56488/#comment237226>
Seems to be that you forgot to handle this error situation.
- DIPAYAN BHOWMICK
On Feb. 13, 2017, 7:35 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56488/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 7:35 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19938
> https://issues.apache.org/jira/browse/AMBARI-19938
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Showing notification on getting error.
> - Other code re-factor
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64
> contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js PRE-CREATION
> contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4d8524e
> contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs e0ceaa2
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2
>
> Diff: https://reviews.apache.org/r/56488/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56488: Hive2: Invalid query execution not handled
properly
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 4:56 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Summary (updated)
-----------------
Hive2: Invalid query execution not handled properly
Bugs: AMBARI-19938
https://issues.apache.org/jira/browse/AMBARI-19938
Repository: ambari
Description
-------
- Showing notification on getting error.
- Other code re-factor
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64
contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4d8524e
contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs e0ceaa2
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2
Diff: https://reviews.apache.org/r/56488/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56488: Hive2: xxx; never returns
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/
-----------------------------------------------------------
(Updated Feb. 13, 2017, 7:35 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-19938
https://issues.apache.org/jira/browse/AMBARI-19938
Repository: ambari
Description (updated)
-------
- Showing notification on getting error.
- Other code re-factor
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64
contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4d8524e
contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs e0ceaa2
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2
Diff: https://reviews.apache.org/r/56488/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56488: Hive2: xxx; never returns
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/
-----------------------------------------------------------
(Updated Feb. 13, 2017, 7:33 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
Bugs: AMBARI-19938
https://issues.apache.org/jira/browse/AMBARI-19938
Repository: ambari
Description
-------
Added a modal for error.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64
contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js PRE-CREATION
contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4d8524e
contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs e0ceaa2
contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2
Diff: https://reviews.apache.org/r/56488/diff/
Testing
-------
manually tested.
Thanks,
Pallav Kulshreshtha
Re: Review Request 56488: Hive2: xxx; never returns
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/#review164899
-----------------------------------------------------------
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js
<https://reviews.apache.org/r/56488/#comment236740>
Please set a meaningful summary.
- Nitiraj Rathore
On Feb. 9, 2017, 11:25 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56488/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 11:25 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19938
> https://issues.apache.org/jira/browse/AMBARI-19938
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added a modal for error.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js dcf27b4
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8ee8e87
>
> Diff: https://reviews.apache.org/r/56488/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>
Re: Review Request 56488: Hive2: xxx; never returns
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/#review164902
-----------------------------------------------------------
I guess alert-message is a good candidate for this, rather than introducing a modal. This is inline with what was happening in the old version of the view. Please fix it.
- DIPAYAN BHOWMICK
On Feb. 9, 2017, 11:25 a.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56488/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 11:25 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19938
> https://issues.apache.org/jira/browse/AMBARI-19938
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added a modal for error.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js dcf27b4
> contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8ee8e87
>
> Diff: https://reviews.apache.org/r/56488/diff/
>
>
> Testing
> -------
>
> manually tested.
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>