[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1370: MINIFICPP-1866 Secure connection for ListenSyslog, ListenTCP

[GitBox <gi...@apache.org>]

lordgamez commented on code in PR #1370:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1370#discussion_r947909188


##########
extensions/civetweb/tests/ListenHTTPTests.cpp:
##########
@@ -60,15 +60,15 @@ class ListenHTTPTestsFixture {
     LogTestController::getInstance().setTrace<minifi::processors::ListenHTTP>();
     LogTestController::getInstance().setTrace<minifi::processors::ListenHTTP::Handler>();
     LogTestController::getInstance().setDebug<minifi::processors::LogAttribute>();
-    LogTestController::getInstance().setDebug<utils::HTTPClient>();

Review Comment:
   Those changes were actually needed, as we now have a header using `minifi::test::utils` namespace included and the tests are in the `minifi::test` namespace. Due to this the compiler expects HTTPClient to be in the `minifi::test::utils` namespace if we only specify it as `utils::HTTPClient`. It returns a compiler error: `error: ‘HTTPClient’ is not a member of ‘org::apache::nifi::minifi::test::utils’; did you mean ‘org::apache::nifi::minifi::utils::HTTPClient’`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org