You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "pepness (via GitHub)" <gi...@apache.org> on 2023/02/10 04:15:50 UTC
[GitHub] [netbeans] pepness opened a new pull request, #5462: Update ServletJSPAPI to the Jakarta family (covers up to Jakarta EE 8)
pepness opened a new pull request, #5462:
URL: https://github.com/apache/netbeans/pull/5462
- Change license type to EPL v2.0
- Use one license file for the external jars and one for the generated jar
- Use jakarta family jars
- Update servlet-api from 3.1 to 4.0
- Update jsp-api from 2.3.3 to 2.3.6
- Update gf-client-module from 5.0 to 5.1.0
- Remove unused versions of servlet-api, they weren't included in the
generated.jar
- Change servlet version from 3.1 to 4.0 in the name of the generated
jar and all references to it
- Remove xsd files that do not belong to the javax naming
(up to Jakarta EE 8)
- Override missing methods from Servlet 4.0
- Add new entry to ignore-overlaps for the jakarta.servlet-api jar
NetBeans Testing:
- Verify successful execution of libraries and licenses Ant test
- Verify successful execution of Verify Sigtests
- Verify successful execution of unit tests for modules servletjspapi, web.core, web.core.syntax, web.el, web.jsf.editor, web.jspparser, web.project
- Verify that the jars are in the Ant Library
- Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
- Successfully test web apps with jsp and servelts and verify that it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness merged pull request #5462: Update ServletJSPAPI to the Jakarta family (covers up to Jakarta EE 8)
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness merged PR #5462:
URL: https://github.com/apache/netbeans/pull/5462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5462: Update ServletJSPAPI to the Jakarta family (covers up to Jakarta EE 8)
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #5462:
URL: https://github.com/apache/netbeans/pull/5462#discussion_r1103574507
##########
enterprise/web.jspparser/src/org/netbeans/modules/web/jspparser/ParserServletContext.java:
##########
@@ -660,6 +660,12 @@ public Dynamic addServlet(String string, Servlet srvlt) {
public Dynamic addServlet(String string, Class<? extends Servlet> type) {
return null;
}
+
+ @Override
+ public Dynamic addJspFile(String servletName, String jspFile) {
+ System.err.println("** addJspFile(servletName,jspFile)");
Review Comment:
Should this be a logger or even completely removed?
##########
enterprise/web.jspparser/src/org/netbeans/modules/web/jspparser/ParserServletContext.java:
##########
@@ -293,7 +293,7 @@ public Enumeration getInitParameterNames() {
*/
public int getMajorVersion() {
- return (3);
+ return (4);
Review Comment:
The parentheses are not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on a diff in pull request #5462: Update ServletJSPAPI to the Jakarta family (covers up to Jakarta EE 8)
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on code in PR #5462:
URL: https://github.com/apache/netbeans/pull/5462#discussion_r1103863736
##########
enterprise/web.jspparser/src/org/netbeans/modules/web/jspparser/ParserServletContext.java:
##########
@@ -293,7 +293,7 @@ public Enumeration getInitParameterNames() {
*/
public int getMajorVersion() {
- return (3);
+ return (4);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on a diff in pull request #5462: Update ServletJSPAPI to the Jakarta family (covers up to Jakarta EE 8)
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on code in PR #5462:
URL: https://github.com/apache/netbeans/pull/5462#discussion_r1103872335
##########
enterprise/web.jspparser/src/org/netbeans/modules/web/jspparser/ParserServletContext.java:
##########
@@ -660,6 +660,12 @@ public Dynamic addServlet(String string, Servlet srvlt) {
public Dynamic addServlet(String string, Class<? extends Servlet> type) {
return null;
}
+
+ @Override
+ public Dynamic addJspFile(String servletName, String jspFile) {
+ System.err.println("** addJspFile(servletName,jspFile)");
Review Comment:
It is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists