You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "Marshall Schor (JIRA)" <ui...@incubator.apache.org> on 2009/08/20 16:07:15 UTC
[jira] Created: (UIMA-1506) update Bean Scripting Framework
Annotator with info about licenses and documentation
update Bean Scripting Framework Annotator with info about licenses and documentation
------------------------------------------------------------------------------------
Key: UIMA-1506
URL: https://issues.apache.org/jira/browse/UIMA-1506
Project: UIMA
Issue Type: Improvement
Components: Sandbox-BSFAnnotator
Reporter: Marshall Schor
Assignee: Marshall Schor
Priority: Minor
Fix For: 2.3AS
update with info received in email: http://markmail.org/thread/e3q5gk6h42jggg5c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (UIMA-1506) update Bean Scripting Framework
Annotator with info about licenses and documentation
Posted by "Marshall Schor (JIRA)" <ui...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marshall Schor closed UIMA-1506.
--------------------------------
Resolution: Fixed
> update Bean Scripting Framework Annotator with info about licenses and documentation
> ------------------------------------------------------------------------------------
>
> Key: UIMA-1506
> URL: https://issues.apache.org/jira/browse/UIMA-1506
> Project: UIMA
> Issue Type: Improvement
> Components: Sandbox-BSFAnnotator
> Reporter: Marshall Schor
> Assignee: Marshall Schor
> Priority: Minor
> Fix For: 2.3AS
>
> Attachments: BSFAnnotator.zip
>
>
> update with info received in email: http://markmail.org/thread/e3q5gk6h42jggg5c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (UIMA-1506) update Bean Scripting Framework
Annotator with info about licenses and documentation
Posted by "Marshall Schor (JIRA)" <ui...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marshall Schor updated UIMA-1506:
---------------------------------
Fix Version/s: (was: 2.3AS)
2.3S
> update Bean Scripting Framework Annotator with info about licenses and documentation
> ------------------------------------------------------------------------------------
>
> Key: UIMA-1506
> URL: https://issues.apache.org/jira/browse/UIMA-1506
> Project: UIMA
> Issue Type: Improvement
> Components: Sandbox-BSFAnnotator
> Reporter: Marshall Schor
> Assignee: Marshall Schor
> Priority: Minor
> Fix For: 2.3S
>
> Attachments: BSFAnnotator.zip
>
>
> update with info received in email: http://markmail.org/thread/e3q5gk6h42jggg5c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (UIMA-1506) update Bean Scripting Framework Annotator
with info about licenses and documentation
Posted by Marshall Schor <ms...@schor.com>.
Olivier Terrier wrote:
>>> One question: The POM for this project specifies that the Jar have
>>> included "resources", which then become available on the class path.
>>>
>>> The resources included are
>>> BeanshellTestAnnotator.xml
>>> BSFAggregatedAE.xml
>>> BSFAnnotator.xml
>>> NICKNAMES.bsh
>>> RhinoTestAnnotator.xml
>>> TEST.bsh
>>> TEST.js
>>>
>>>
>> I see these are needed for running the tests. I'm moving them to the
>> src/test/resources files. That way, maven will use them for running
>> the
>> tests, but they won't be packaged in the Jar file that maven builds.
>>
>> Let me know if I'm missing something here...
>>
> Yes, they are here for testing purposes so I guess moving them to the test/resources dir is OK
>
Ok, did that. I've also updated the readme to indicate that same
descriptors and examples can be found in the src/test/resources folder.
Will check in soon...
-Marshall
> O.
>
RE: [jira] Updated: (UIMA-1506) update Bean Scripting Framework Annotator with info about licenses and documentation
Posted by Olivier Terrier <ol...@temis.com>.
> > One question: The POM for this project specifies that the Jar have
> > included "resources", which then become available on the class path.
> >
> > The resources included are
> > BeanshellTestAnnotator.xml
> > BSFAggregatedAE.xml
> > BSFAnnotator.xml
> > NICKNAMES.bsh
> > RhinoTestAnnotator.xml
> > TEST.bsh
> > TEST.js
> >
> I see these are needed for running the tests. I'm moving them to the
> src/test/resources files. That way, maven will use them for running
> the
> tests, but they won't be packaged in the Jar file that maven builds.
>
> Let me know if I'm missing something here...
Yes, they are here for testing purposes so I guess moving them to the test/resources dir is OK
O.
Re: [jira] Updated: (UIMA-1506) update Bean Scripting Framework Annotator
with info about licenses and documentation
Posted by Marshall Schor <ms...@schor.com>.
Marshall Schor wrote:
> Olivier Terrier (JIRA) wrote:
>
>> [ https://issues.apache.org/jira/browse/UIMA-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Olivier Terrier updated UIMA-1506:
>> ----------------------------------
>>
>> Attachment: BSFAnnotator.zip
>>
>> Marshall: I did a quick review of the code to:
>> 1. Fix the NullPointerException when running the testAnnotatorAggregated
>> 2. migrate the BSFAnnotator from the old-way JTextAnnotator_ImplBase to JCasAnnotator_ImplBase
>> 3. add a few generics to avoid warnings
>>
>> Attached you will find a zip that contains the files that have been modified
>>
>>
> Thanks, Olivier; I applied the changes and will check them in soon.
>
> One question: The POM for this project specifies that the Jar have
> included "resources", which then become available on the class path.
>
> The resources included are
> BeanshellTestAnnotator.xml
> BSFAggregatedAE.xml
> BSFAnnotator.xml
> NICKNAMES.bsh
> RhinoTestAnnotator.xml
> TEST.bsh
> TEST.js
>
I see these are needed for running the tests. I'm moving them to the
src/test/resources files. That way, maven will use them for running the
tests, but they won't be packaged in the Jar file that maven builds.
Let me know if I'm missing something here...
Cheers. -Marshall
> Should all of these be packaged in the Jar by the build step? I guess I
> don't understand the reason these should be in the Jar.
>
> The resources
> org.apache.uima.annotator.bsf.BSFAnnotatorMessages_fr.properties
> org.apache.uima.annotator.bsf.BSFAnnotatorMessages.properties
> are also included, but these I believe do belong in the Jar.
>
> Thanks for your advice :-) -Marshall
>
>
>
>
>
Re: [jira] Updated: (UIMA-1506) update Bean Scripting Framework Annotator
with info about licenses and documentation
Posted by Marshall Schor <ms...@schor.com>.
Olivier Terrier (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/UIMA-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Olivier Terrier updated UIMA-1506:
> ----------------------------------
>
> Attachment: BSFAnnotator.zip
>
> Marshall: I did a quick review of the code to:
> 1. Fix the NullPointerException when running the testAnnotatorAggregated
> 2. migrate the BSFAnnotator from the old-way JTextAnnotator_ImplBase to JCasAnnotator_ImplBase
> 3. add a few generics to avoid warnings
>
> Attached you will find a zip that contains the files that have been modified
>
Thanks, Olivier; I applied the changes and will check them in soon.
One question: The POM for this project specifies that the Jar have
included "resources", which then become available on the class path.
The resources included are
BeanshellTestAnnotator.xml
BSFAggregatedAE.xml
BSFAnnotator.xml
NICKNAMES.bsh
RhinoTestAnnotator.xml
TEST.bsh
TEST.js
Should all of these be packaged in the Jar by the build step? I guess I
don't understand the reason these should be in the Jar.
The resources
org.apache.uima.annotator.bsf.BSFAnnotatorMessages_fr.properties
org.apache.uima.annotator.bsf.BSFAnnotatorMessages.properties
are also included, but these I believe do belong in the Jar.
Thanks for your advice :-) -Marshall
[jira] Updated: (UIMA-1506) update Bean Scripting Framework
Annotator with info about licenses and documentation
Posted by "Olivier Terrier (JIRA)" <ui...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/UIMA-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Terrier updated UIMA-1506:
----------------------------------
Attachment: BSFAnnotator.zip
Marshall: I did a quick review of the code to:
1. Fix the NullPointerException when running the testAnnotatorAggregated
2. migrate the BSFAnnotator from the old-way JTextAnnotator_ImplBase to JCasAnnotator_ImplBase
3. add a few generics to avoid warnings
Attached you will find a zip that contains the files that have been modified
Cheers
Olivier
> update Bean Scripting Framework Annotator with info about licenses and documentation
> ------------------------------------------------------------------------------------
>
> Key: UIMA-1506
> URL: https://issues.apache.org/jira/browse/UIMA-1506
> Project: UIMA
> Issue Type: Improvement
> Components: Sandbox-BSFAnnotator
> Reporter: Marshall Schor
> Assignee: Marshall Schor
> Priority: Minor
> Fix For: 2.3AS
>
> Attachments: BSFAnnotator.zip
>
>
> update with info received in email: http://markmail.org/thread/e3q5gk6h42jggg5c
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.